From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932479AbcHKHEN (ORCPT ); Thu, 11 Aug 2016 03:04:13 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:57650 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932369AbcHKHD6 (ORCPT ); Thu, 11 Aug 2016 03:03:58 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Thu, 11 Aug 2016 08:03:26 +0100 From: Chris Wilson To: akash.goel@intel.com Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Tvrtko Ursulin Subject: Re: [PATCH] relay: Use per CPU constructs for the relay channel buffer pointers Message-ID: <20160811070326.GA12148@nuc-i3427.alporthouse.com> References: <1470899140-21205-1-git-send-email-akash.goel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470899140-21205-1-git-send-email-akash.goel@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 12:35:40PM +0530, akash.goel@intel.com wrote: > From: Akash Goel > > relay essentially needs to maintain the per CPU array of channel buffer > pointers but it manually creates that array. > Instead its better to avail the per CPU constructs, provided by the > kernel, to allocate & access the array of pointer to channel buffers. > > Cc: Chris Wilson > Cc: Tvrtko Ursulin > Signed-off-by: Akash Goel This has the benefit of being a mechnical change and I could not think of a better way to express the per-cpu indirection. relay.h should probably include so that it pulls in the percpu api explicitly. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre