From: Mark Brown <broonie@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jaffer Kapasi <jkapasi@linear.com>
Subject: Re: [PATCH] regulator: Add LTC3676 support
Date: Thu, 11 Aug 2016 10:45:09 +0100 [thread overview]
Message-ID: <20160811094509.GP9347@sirena.org.uk> (raw)
In-Reply-To: <CAJ+vNU3s=qxJr8x=ScnyEV0UKkD_gTOnMyY8oGuzVs14hTW0Ng@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]
On Wed, Aug 10, 2016 at 05:44:55PM -0700, Tim Harvey wrote:
> On Wed, Aug 10, 2016 at 4:41 AM, Mark Brown <broonie@kernel.org> wrote:
> >> +/* LDO1 always on fixed 0.8V-3.3V via scalar via R1/R2 feeback res */
> >> +static struct regulator_ops ltc3676_fixed_standby_regulator_ops = {
> >> +};
> > Remove this, it's pointless.
> as I'm using macro's to define the ops, removing this ends up breaking
> compilation:
> do you know of some macro foo to best handle this? Part of me wants to
> ditch the macro's and just simply declare the array of regulators
> directly as its much easier to read/follow.
Just don't use the macro for that regulator?
> >> + if (!rdesc->r1 || !rdesc->r2)
> >> + return;
> > This is a bug if we ever get here, we should be complaining loudly.
> This is now refactored due to using the core code for of parsing, but
> is it ok/standard to allow unused regulators to be not-defined in the
> dt and if so how do I handle that? Currently my test board uses 7 of
> the 8 regulators but the unused one is still registered with linux.
Substitute in versions of the ops that don't have any of the voltage
operations since without the dividers you can't support them, or make
the voltage operations return -EINVAL.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-11 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 23:36 [PATCH] regulator: Add LTC3676 support Tim Harvey
2016-08-10 11:41 ` Mark Brown
2016-08-11 0:44 ` Tim Harvey
2016-08-11 9:45 ` Mark Brown [this message]
2016-08-11 20:48 ` Tim Harvey
2016-08-12 9:21 ` Mark Brown
2016-08-10 22:28 ` Rob Herring
2016-08-11 0:46 ` Tim Harvey
2016-08-15 19:40 ` [PATCH v2] " Tim Harvey
2016-08-16 11:30 ` Applied "regulator: Add LTC3676 support" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811094509.GP9347@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jkapasi@linear.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).