From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Anton Blanchard <anton@samba.org>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
bsingharora@gmail.com, naveen.n.rao@linux.vnet.ibm.com,
ananth@in.ibm.com, mhiramat@kernel.org, wangnan0@huawei.com,
namhyung@kernel.org
Subject: Re: [PATCH 2/2] perf ppc64le: Fix probe location when using DWARF
Date: Thu, 11 Aug 2016 08:50:26 -0300 [thread overview]
Message-ID: <20160811115026.GA27651@kernel.org> (raw)
In-Reply-To: <57ABFF88.8030905@linux.vnet.ibm.com>
Em Thu, Aug 11, 2016 at 10:01:04AM +0530, Ravi Bangoria escreveu:
>
>
> On Thursday 11 August 2016 05:24 AM, Anton Blanchard wrote:
> > Hi,
> >
> > > Powerpc has Global Entry Point and Local Entry Point for functions.
> > > LEP catches call from both the GEP and the LEP. Symbol table of ELF
> > > contains GEP and Offset from which we can calculate LEP, but debuginfo
> > > does not have LEP info.
> > >
> > > Currently, perf prioritize symbol table over dwarf to probe on LEP
> > > for ppc64le. But when user tries to probe with function parameter,
> > > we fall back to using dwarf(i.e. GEP) and when function called via
> > > LEP, probe will never hit.
> > This patch causes a build failure for me on ppc64le:
> >
> > libperf.a(libperf-in.o): In function `arch__post_process_probe_trace_events':
> >
> > tools/perf/arch/powerpc/util/sym-handling.c:109: undefined reference to `get_target_map'
>
> Thanks Anton. Sorry, I should have caught that.
>
> @Arnaldo, Can you please pick this up. I've prepared this on top of
> acme/perf/core.
>
>
> From 89c977ae9c3ae35c78b16cddabcf2b01d3cf5cc8 Mon Sep 17 00:00:00 2001
> From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> Date: Wed, 10 Aug 2016 23:13:45 -0500
> Subject: [PATCH] perf ppc64le: Fix build failure when no dwarf support
>
> Fix perf build failure on ppc64le because of Commit 99e608b5954c ("perf
> probe ppc64le: Fix probe location when using DWARF")
Can you please provide a better explanation? I had to look at the patch
to understand what it was fixing, and then the patch adds LIBELF_SUPPORT
ifdefs while the patch description, talks about DWARF.
Anyway, Anton, does this fix the problem for you?
- Arnaldo
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
> tools/perf/arch/powerpc/util/sym-handling.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/arch/powerpc/util/sym-handling.c
> b/tools/perf/arch/powerpc/util/sym-handling.c
> index 8d4dc97..c27a51a 100644
> --- a/tools/perf/arch/powerpc/util/sym-handling.c
> +++ b/tools/perf/arch/powerpc/util/sym-handling.c
> @@ -97,6 +97,7 @@ void arch__fix_tev_from_maps(struct perf_probe_event *pev,
> }
> }
>
> +#ifdef HAVE_LIBELF_SUPPORT
> void arch__post_process_probe_trace_events(struct perf_probe_event *pev,
> int ntevs)
> {
> @@ -118,5 +119,6 @@ void arch__post_process_probe_trace_events(struct
> perf_probe_event *pev,
> }
> }
> }
> +#endif
>
> #endif
> --
> 2.7.4
next prev parent reply other threads:[~2016-08-11 11:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 6:23 [PATCH 1/2] perf: Add function to post process kernel trace events Ravi Bangoria
2016-08-09 6:23 ` [PATCH 2/2] perf ppc64le: Fix probe location when using DWARF Ravi Bangoria
2016-08-09 14:02 ` Masami Hiramatsu
2016-08-09 15:09 ` Arnaldo Carvalho de Melo
2016-08-09 19:21 ` [tip:perf/urgent] perf probe " tip-bot for Ravi Bangoria
2016-08-10 23:54 ` [PATCH 2/2] perf " Anton Blanchard
2016-08-11 4:31 ` Ravi Bangoria
2016-08-11 11:50 ` Arnaldo Carvalho de Melo [this message]
2016-08-11 13:21 ` Ravi Bangoria
2016-08-11 14:49 ` Arnaldo Carvalho de Melo
2016-08-11 17:40 ` Arnaldo Carvalho de Melo
2016-08-12 6:06 ` Anton Blanchard
2016-08-12 13:01 ` Arnaldo Carvalho de Melo
2016-08-16 18:14 ` [tip:perf/urgent] perf ppc64le: Fix build failure when libelf is not present tip-bot for Ravi Bangoria
2016-08-11 15:49 ` [PATCH 2/2] perf ppc64le: Fix probe location when using DWARF Arnaldo Carvalho de Melo
2016-08-09 19:20 ` [tip:perf/urgent] perf probe: Add function to post process kernel trace events tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811115026.GA27651@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=anton@samba.org \
--cc=bsingharora@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).