From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbcHMOyV (ORCPT ); Sat, 13 Aug 2016 10:54:21 -0400 Received: from mail-sn1nam02on0088.outbound.protection.outlook.com ([104.47.36.88]:6784 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752384AbcHMOyR (ORCPT ); Sat, 13 Aug 2016 10:54:17 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Sat, 13 Aug 2016 17:54:03 +0300 From: Yury Norov To: Andreas Schwab CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 18/19] arm64:ilp32: add vdso-ilp32 and use for signal return Message-ID: <20160813145403.GB24335@yury-N73SV> References: <1466207668-10549-1-git-send-email-ynorov@caviumnetworks.com> <1466207668-10549-19-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AMSPR04CA0044.eurprd04.prod.outlook.com (10.242.87.162) To SN1PR07MB2256.namprd07.prod.outlook.com (10.164.47.150) X-MS-Office365-Filtering-Correlation-Id: aba0d6d9-6e37-4d0b-255f-08d3c389b0cc X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;2:7Hhzf3zioYwFGQgKdkUoCkh/cN8SrMdNMneoiDCCdYpi+lM1PHR8Eu5LpjE+51rOk91PlIW2HlLYLzXuMyyMVXaqEljp5i06ysoUDcPM3ngEVwUWEYDQfQtPuImRC0RPuKQOZ7FCyYmiKZYshq5Ot3SAF150yHeZvbP+mYwQ6lfDPJS2kaMhCx3/wK4CBp8Y;3:6nPDfZXQpWqUrjjxFrPdWsaRIXXQbNQKHg/aeMhKR8LvjDnzrnp02GYqI1ZqSukeF9vNilZTRzoUDx3/7SIOR+JPYiVS8REQyEiateT6O7GlvN8TWXciXU4wKBZP/bBj X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2256; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;25:j2mspkFUvSW1gJsceUp+XbeTk5y9LFbk5aHjPgnND3ggKm3Ym6i8IAnzMWQEvvBDNK+6qrZlNJXxhEUEZ8SaO3eqdIrD5KjX56FJRhMz+TwQ0Gbr1xH1DiXbVjBoCbXkldoHPwOFQSCYhEOdwYN0gJmrSrwCxhLL9e/Ao69Rx8ZeDXCyMV+ZZK9xjL8Qy1Wgzk4/DHRaZmNoLLEB9nZLqtWZrFSMHQPfcgqa4NDveE3BtB7ySwlMcRG23gHnTswISZ4Z0ymb/Kxb0VOTklQZTnW1MeDD5BvhcFHtQAhRZ9eR4+oR23MBDdE3dwG95KHrgV1Z3u81ovzIKoaHSI+iWAUqWOcM1ds4mXUzP1FKr7OoG6dPye7wWQIaO+lqt3N5+kbqFtM5LLbjmpxVpi9WMgH4I/aAPS+DypQXoghP7rvGro3tk/jqg3QDXvqaBWmRUBNI7me985MKFeukNc65bmQOo9h21TopshlPJzz7cvU5tXoO+eQMnyMY6Sn6f7RNYtR31y9YPBVnFYLw4mflEntNOZF0Ww6agtICBPH3//9CoPL3/y5HDYu+3soJQ2FwmPO/+cySHhRdPH7QdUeHushinP8NIs+Do+Z1ihSAWZXJF7263fIbdzG+c5y+6/ZO+MyKrYrUBpEQ/Vj4u19Auc8+ffLqKfttN8rpA6tSjxBT1/RE/+OhIMqtAsqDAfnU3+o4kxQmdRuUaOZCBztbCZZi7OlGCXpjMfmjDPryPOCCAxkok7LbgigctaFMiOUZ6nn/xUHrfQvC0G5QAjGklW/2qgqfZNeiT0FkGXrBBGiYu75F9AgjgKIvRHWj2FgENPHBxsJuIvfy7oGp43/+nfyIq4E9TPzI7t+45ew8xHy+mXDAsx5IGhnucNu/5UtL X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;31:3OGzHPW8iV19A003RUDqfQLX9+6JPdjYuorZtDMx+PoOx/3erOw3k75cx8t/4UGxT+GGjtpgVNWqOuJVfdTtpUMfaNQy68a4dpPWnCeXZ8u4HOkm/TNvJNtUedQtRzgder1yFaZY/IUJfuCkFm57akXRgZp6mbtVSzlAnf1v5U2+qiSP9ggY/g8DmNo1K6BSYu1kMCEQKUeeOy6IRkFTvdb+FAyRMaC5I1RxGyxhHKA=;20:fBag1JJggzmfejNDfPQ8qbzxKexTRX0RXQhCIRPILak3l9s+Rp6mKkRipq6Mm6hK0ZMZr2uCUeApdFb8knOgWGH1hqOxnsAZjhx0zZfEkHouZ0dxlAbbbsaKo92RvzK6lQgdm3YpkUf6nz0z2YN0JaSk66TNsn456UPgS8NQaYRj41M4XpVaXIiSFg7vlGpQD3A+zicH5dSOIQjNvx3c1kn2roSupdSRrVdTsu7jdjjzvsEzAR6TVBod6yKJCgxwasgvCbUk6OVJcSE1kbq3/anm8MIZvE1doZIgwTwn+8+S2CnO8qRL9swnMpwIyMsZJvtrlpqVW+tIyrAt/PZSCrPx5cG2Scvi2umjbzlCrlc3T76kzVzr77xwMTB97FWlO2jSmxFlGzaU+RwcoGd8tep8TxNzunwv7Tj3d5bWpIs4t+jOxOH2BFHosH93OPIkIDQ+e0mTgGmRabJoi31cyA/SCXQhmAEVB5Cvd/lNE7pfMCt2TOAIwyXP4NPa4hmmrPBGp173wj8wbnl0yT2X8swxym/4M9+GzNxNa8sHTAnBuFrb49Car+FFNMavYBO+SRn4WS879l7f4kBsOQoaqYBMeCT4ep+2iJAwwPZB2/k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:SN1PR07MB2256;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2256; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;4:s8wQhoyPiIerbJXzXqy553wTtQkCaWGGMr4dvlNaadWJB2lqZTmru/TDd0rPMtirDBG2uyzCH3kSg2155jarqKERp6umhWN2WYOGHLGjjCIne+LS/n4Ba3N8YvNrvPvp65Vkbmlk0DuylcJYmoIaL9s/OyEq0sY3l/VBVxOyf8Zv7l9JWXZsMD2JtzVAW4Ai3GdWEe+uOvg3TCH+4yvDc6wLz6jXS/zvAmXzNC2kyz2LZCM8SCZJs9fDc0YBBzqzN7ol2wi8JzoRGI4DK75qe7b+NGvoKgqfc4HuArbQiAoNFpw6LmqEVrfIIiSzvMFXfXkDqvIdCoBmHi0P8FMi+993+CY1uEJW6yjRyj9pIv3JimAvGOuUgosyeYgexMtDz527O6eYjAwe03GMSeDk80AyyWO5UtxSXEVIxJnoie6ZLC4HGFutpglI/juGUTtZ X-Forefront-PRVS: 0033AAD26D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(24454002)(189002)(199003)(1076002)(3846002)(92566002)(6116002)(4326007)(66066001)(2906002)(2950100001)(15975445007)(101416001)(77096005)(19580395003)(19580405001)(105586002)(50986999)(76176999)(54356999)(47776003)(7416002)(76506005)(42186005)(23726003)(110136002)(97756001)(9686002)(50466002)(83506001)(46406003)(4001350100001)(97736004)(189998001)(575784001)(33716001)(7736002)(7846002)(305945005)(81166006)(81156014)(8676002)(106356001)(68736007)(33656002)(586003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2256;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2256;23:lyA70Kwa4vonhbqkkvNHFrmTpGSbk6gOtIUqUEpil?= =?us-ascii?Q?2AU7pq5sFzBgeA/6GbyPRowVPWNlv8FMBJwNULpWH2/2PVcaHTyBQfVH0iDZ?= =?us-ascii?Q?IbKeBaWsXj4XajLPWl+BsgFh4TsanG8gKWciZYx/NIzz025I+8V8dlRUITwm?= =?us-ascii?Q?pg8IDbFCR4nGWVub/r8rf9xP9l6WYIlTfYA7bMDM2euUNQdWEOcUEfKynF7s?= =?us-ascii?Q?4uelX+TMKWLUd1+MEmVFncXH4x6D7VSK9KxaOD0GSHQqVwjW3PcY38g96wTp?= =?us-ascii?Q?+E9BcalEJz1EOBcmn5gjVohwYH5U2LlyGX1nvZVY7EIYhsVaGUhCTMadD+ZA?= =?us-ascii?Q?spH/w3lYTCJ8nUEIKr0PbeQmDAhZzgbfUB9pGq2VciHce3nGnDNBDZxu+w9l?= =?us-ascii?Q?Gs0mM7NcvhbxPrhjCtXPLvkBfK7oDvNLWvIV8Q3hQGYbnCrultPDUwhcSnK6?= =?us-ascii?Q?cQWBwZLAObwM9Uhr0pZHo66s4qYK2Tml7ROEdgn6mucY6uaKG24Ia3Gm2zlm?= =?us-ascii?Q?53q4mUqNTmLoOoaX8zXp3ktOeWi6DYDQTPxQSFPQM+adPhw+w6nQ8zvzVf2g?= =?us-ascii?Q?nHoiZG7/X/lbRYuhteChAY7boF26bwGhZJdAkZZyV3DI5qcz1Y45u0gr9GKL?= =?us-ascii?Q?d24TqASYm2bayGXcPapwSoaxCN39vXxBRk4oNn2NSvDur8bFtVXw5oEDOCdj?= =?us-ascii?Q?AOK+a4RVbwRZKx5mCGEaJDSE6TWCZj1KkIyFdUwgTi6MHcI93/YlL6F/Er0C?= =?us-ascii?Q?XhYo5UMkU3Y/EPjO9r/EZIOR07vTG51K2wPLQDOSom5eR0we/O1ZPnROHOtC?= =?us-ascii?Q?To2FxpqQBZLBoMTXYuOwPtFDcHFqO1zhdJ6m8ZaPtUOozGr4FDLV78rQNLYK?= =?us-ascii?Q?6QHqVjZxyqnqb41oGZAebyLdROPCZl9gBez6/zd7GB4TyDacvMsDtBDllHs1?= =?us-ascii?Q?JSCQnh0LHdcYzSn7FramNwNruVBTyumoCbQAjOQgWrLgF21abgt9Fr8+aYzA?= =?us-ascii?Q?8/UHQ1Xes7CwSjnlgTpwhOVWvispgyYmIt4JKrLd5z92QpSEshO/g66dBu9V?= =?us-ascii?Q?QPhuyV3wGXawCUSl6ipqJJOhdqdR6yL372yCp4IHE2TZ2pH7TXZjiBpVqJK+?= =?us-ascii?Q?M9ZKMy0XO2u/VQTDMCNtdz1nTUj2tV1F3mhQtQSfqJ3HErNBpNm1TYzlBJb2?= =?us-ascii?Q?wi8yufh5qAYlFdxOeUKADoVlGyOWaNtFFlJ996aZzS7P+YlTqRvL2mxTCcrk?= =?us-ascii?Q?lwBMl8JgPTw7a9oEiX0HYEVn7CBlg5joOx6OzqO?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;6:+two/iZCs0og2ymimQ1PajGLPpPOgpiGBsroeDl/+WKEVfygGs80jIa3E0v1DLN72kJN+EAPPbv1lqTSR3qmEcS1EgypMRFoWa0CLHZfahw3VFNOYeRf1AJlBrk5xW43iCkyo3JXNkwF9AzNwMdfkblb+LD4+ko6t+tbqQR3eOfUh57RH8T8+E1x66nmgLsy2sW9eV1ZWN+OVyqEZZsLQI1xn0ijEj5AJLlS7W38KGUMVZ2AEAW6aKozfwu/fKpI5DYMpT4Ekrl6nB/IepGPP86yV2/2U0y5biCC2sFQ2Ck=;5:TZR6vjVo0P/zSaHeTIL5Klzwaq9O1ypmJlp2z27iBcuntZJrr2m027ooltGNwT1hAlXx0hM7PGcf8LQvXhDdk1P3du6ugWsPQnxu9gqfsjWqGTJE59lh2xqjDi0i8nH0MckDKHfy2xmOdYNl31kNjA==;24:FWiPKWNVqX8WJEWxrqCxBs/UXK39KN3V6qOB4YTLgGzJseHuxAcveXzVCWAG9+orIPRw9OJ3J79ZgTuM9WQqoSe8OIdkOCpMEvVzHmKr5wY=;7:nGgyQRQhUl8pqF0T+7ge/H+0RRgBDZ4sMptWmtjpHU/bqK4wndhFA4f0u2D+I/+z8veRr6nsZkrkZiEhfjloUzNfC/tkEnx5Hw1u9AE6+goap3IX8An1uYcrbQWX0+fTLj4bPO+ZOjMz1JhJ/GxbXRV0Pcodh9KRmZ54qixWkNitxljzQpG4sNZx5LNx4XYEKEB2YkSAOQP310tTWzFtVqvxmKVnCa7Ba2rkWd4QoOY5thAHBRqa22bCgf6U9JBT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2016 14:54:12.9012 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2256 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2016 at 04:54:17PM +0200, Andreas Schwab wrote: > Yury Norov writes: > > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c > > index 2a0de6f..e48ea34 100644 > > --- a/arch/arm64/kernel/vdso.c > > +++ b/arch/arm64/kernel/vdso.c > > @@ -40,6 +40,12 @@ extern char vdso_start, vdso_end; > > static unsigned long vdso_pages; > > static struct page **vdso_pagelist; > > > > +#ifdef CONFIG_ARM64_ILP32 > > +extern char vdso_ilp32_start, vdso_ilp32_end; > > +static unsigned long vdso_ilp32_pages; > > +static struct page **vdso_ilp32_pagelist; > > +#endif > > + > > /* > > * The vDSO data page. > > */ > > @@ -110,24 +116,29 @@ int aarch32_setup_vectors_page(struct linux_binprm *bprm, int uses_interp) > > } > > #endif /* CONFIG_AARCH32_EL0 */ > > > > -static struct vm_special_mapping vdso_spec[2]; > > - > > -static int __init vdso_init(void) > > +static int __init vdso_init_common(char *vdso_start, char *vdso_end, > > Using the same name for the parameter as for the global variable is > dangerous .... > > > + unsigned long *vdso_pagesp, > > + struct page ***vdso_pagelistp, > > + struct vm_special_mapping* vdso_spec) > > { > > int i; > > + unsigned long vdso_pages; > > + struct page **vdso_pagelist; > > > > - if (memcmp(&vdso_start, "\177ELF", 4)) { > > + if (memcmp(vdso_start, "\177ELF", 4)) { > > ... because forgetting to remove & can be fatal, and your compiler may > not even warn you. > > Andreas. Fixed. See here: https://github.com/norov/linux/tree/ilp32-4.8 Thanks. Yury.