Hi Paul, On Sun, Aug 14, 2016 at 07:54:28PM -0400, Paul Gortmaker wrote: > On Fri, Aug 12, 2016 at 11:14 PM, Sebastian Reichel wrote: > > This driver adds support for Nokia H4+ procotol used > > for example by Nokia's internet tablets (N770 - N950). > > > > [...] > > > > +config BT_HCIUART_NOKIA > > + bool "UART Nokia H4+ protocol support" > > If the option is a bool, then you don't need module.h or any MODULE > macros, nor do you need any __exit or unregister related code. > > Alternatively, if there is a use case for it to be modular, then maybe you > want to change the above to a tristate. Actually it is bool and modular: It becomes part of the module configured by the tristate CONFIG_BT_HCIUART option. -- Sebastian