From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752195AbcHOGCZ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Aug 2016 02:02:25 -0400
Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:23206 "EHLO
	mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750977AbcHOGCY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Aug 2016 02:02:24 -0400
Date: Mon, 15 Aug 2016 13:57:41 +0800
From: Jisheng Zhang <jszhang@marvell.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
CC: Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Kees Cook <keescook@chromium.org>,
        "Catalin Marinas" <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/4] arm64: kaslr: Fix incorrect placement of
 __initdata and __read_mostly
Message-ID: <20160815135741.35e60cd1@xhacker>
In-Reply-To: <20160815125214.2727bf88@xhacker>
References: <1470988871-2799-1-git-send-email-jszhang@marvell.com>
	<1470988871-2799-4-git-send-email-jszhang@marvell.com>
	<CAKv+Gu_ci37u6av9gjchBTVwoMCiqdnwtnDHxLT3cV3+kG0wUw@mail.gmail.com>
	<20160815125214.2727bf88@xhacker>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-15_01:,,
 signatures=0
X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000
 definitions=main-1608150070
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ard,

On Mon, 15 Aug 2016 12:52:14 +0800 Jisheng Zhang wrote:

> Hi Ard,
> 
> On Fri, 12 Aug 2016 14:02:40 +0200 Ard Biesheuvel wrote:
> 
> > Hi Jisheng,
> > 
> > On 12 August 2016 at 10:01, Jisheng Zhang <jszhang@marvell.com> wrote:  
> > > __initdata and __read_mostly should be placed after the variable name
> > > for the variable to be placed in the intended section.
> > >    
> > 
> > Why?  
> 
> include/linux/init.h says something as:
> 
>  * For initialized data:
>  * You should insert __initdata or __initconst between the variable name
>  * and equal sign followed by value, e.g.:
>  *
>  * static int init_variable __initdata = 0;
>  * static const char linux_logo[] __initconst = { 0x32, 0x36, ... };
> 
> and examples in gcc manual also put __attribute__ (...) after variable name.
> 
> https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html#Common-Variable-Attributes
> 
> Then I grep the source, found most lines (especially arch/arm64/*) put the
> __initdata and __read_mostly after the variable name.
> 
> However, I built the code with three different gcc, the result looks identical
> no matter where these markers put. So the commit msg looks wrong, what about
> changes it as
> 
> "put __initdata and __read_mostly after the variable name
> to keep the style consistent"?

After some consideration, I want to drop this patch in newer version since
it's not a bug, just "style"

Thanks for your reviewing,
Jisheng