From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932366AbcHOOax (ORCPT ); Mon, 15 Aug 2016 10:30:53 -0400 Received: from mail-co1nam03on0088.outbound.protection.outlook.com ([104.47.40.88]:32160 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752488AbcHOOas (ORCPT ); Mon, 15 Aug 2016 10:30:48 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Mon, 15 Aug 2016 17:30:28 +0300 From: Yury Norov To: Andreas Schwab CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 01/19] compat ABI: use non-compat openat and open_by_handle_at variants Message-ID: <20160815143028.GA7193@yury-N73SV> References: <1466207668-10549-1-git-send-email-ynorov@caviumnetworks.com> <1466207668-10549-2-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: DB5PR10CA0007.EURPRD10.PROD.OUTLOOK.COM (10.165.4.145) To DM3PR07MB2250.namprd07.prod.outlook.com (10.164.33.148) X-MS-Office365-Filtering-Correlation-Id: 0f3c1617-1484-4fd6-ae86-08d3c518bb08 X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2250;2:X7pY4d0PJ8Q2d2EVJvdpdWG4oXmbNuMg+gnAphuImyKd9YrlOCTqyhqBEmvkurOd/BVbS5r6xQAWkKOXQu0YLmtkUSGSJX+qxoyL4EnJvR/O7Mq5sGVQ5adAXgGk4CDki0Q7tB/DYN0EfPp0mV31e13/Seb2wPn84nORuRhNS9bE6v/Wde548ag9EUor5Zf7;3:Sde71iylbCVso241Pur0XrqOwj2V0nwLT5ReEzqnJfSXyolUhICZ4Km+TV3dBjftAE2y6hVkr0ZQzcB0oWD2JWPMi+B1MlfnQgkMlzzlUl4bkXRvfToWgQqUIi94sDl8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2250; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2250;25:5MsUX7JuU/zTfTE1a6lXFFJlvAiWAmPL5c6Se3SGtmD31iT7cWw3ki/8S7fib0zgWrT6976rCd12VxkYgc43Ml4v1igAfyrchd5VIEWZ/jZwtd+HadTQ+VKnqSgG8KlP0SLyRSREYqwRnmqPp6Kpvu1vmjOmHJRlhMaKmlLrJM3eAaPFqdi59RjWoExVGD63q8mtcrOFuJdiTHMBh13g5arrdYkB0krOaMglxYoA+Bl9rWCLKWI4FWbe5VaBXFr93YDyDUsUXg5y2yl2k5XPBaEqcG/EHERTffoiVt6c3QOQzKI3fa2xdmFuH46+4dXnp04GZ7nXzP67M8um/pTycR9gwALUAecIy5ICn9xt4FT+fBoqDZaxaw8kRjbrZxmGGcMjAjht6iAyZKFiycFhQzC+JwGWwjhzaltmL3XL/bKc2auYqqqLdezMtxxWdJ57pgIOpxQ8/d1/BcghQcFpm7bwZZ07abBhgpUF6IL8+f6mzEtOhSX7f+GKHU+ILlV8HOaAX37I++yUB/TpyP3tNxt8yR0L5MArfjC/EFK7b7x7kOWZn2Htjk/EK0iKwOWCMJrBvmj41f28pAumygrZFrCfX9fYPXg7g+ElM45H0ZQOU7Ed5B3fRvhVC+a3VeVCXoGTK5MraBI7QeWw0oy4TbiukEkSFd/dsakVh5mnwsgUYAFVUeAj1LVXKQYTuAd5znHn4QpLd7qp/0EMuBhSoMmNDsbJntKcRf6QUpGdqJtBrLVU6F4P+uU3nMSVZrr0IwBkzyN1X1V9E2mS5Tv1NoTQHMJUybCHmMnldd6OsFShn0cbB/MbQ6PxY2O0Ddlbw6zU43aRSBoSj15JLGwc1dRhfMbOVlRTOJARBzgaOuY= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2250;31:UU0Et6TaLHU2gU2xPYZQOxsm4IaoEGTE0FJXlwpHcKZmV0F8aYu54nxWpbYTCmd1NtKOlZvfqqjhalM9wOQHR5e3L69Q4ECudZjep4ISk+WjVeWJW8OKxE9qjZEYuO2/bYIPBWaxzCw/f5irjXbockXqYoF+sqP2ryguru4+3uyAsm9++XzIWNtJsKpaJaynxZqAy4aeKGS33btaQ8EKuae7Aue6IPEtP+NPJbJQHQ8=;20:qHFGr6bfRN8nc13ARO62aD5tuudMKTgQGeWop7FMPpNBizLzhS5n9urZCdZ7HlWo8hboKGUkNePbFK21WWtoIX0/JHq7xYCqH7NMUBw3FR3VlLyWtYTJvR54ndF+X7EOsbSfbcalCfZoIt8r2y/BRT5SVi+oFXyKcjFxNcNoD7wcVlLSDDL7o13tJJZLoK7nmJneIXb6FYEWL5oNFBntmfGv9aXGFPhdMgsNF/E1zixLbPDN+0Gt+WnMS+2pgShHJHw7ZA65B2ZvJKcNk0NZfTB0j/0CGGpR63jOlVRzRBGChWYNYXViPhZtusKW7cYod3m+VivPaQRnueNIh9BmgIvf364CAPlx3c/gqmwx/qyXdJFEyYxQCy8MGY/o6blPIR8uaWsJa76s9Z1VYjhbDL2QDNcX+ePN7hQIzALOBkTijMhttrYhr1JPSYKRmqS/Iy1yfsq2XigrLFQXr2Ql3QTM40pAina7YsysKrOsV4oXeNkLb4V3zA+Qc6CnmRj0C3csQkkEA42xph65fJd+M7chtXwPy5a6auyUhf4D5YndFZk94zkI3rXO/tLqFHyVJVnKHUCryxn1Yd9kBCitfhYtLWBXPeZL8yFLV0r+xdo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(36064498253994); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:DM3PR07MB2250;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2250; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2250;4:BZWJ6p5MbIbfZ06ScIVhlZxf0qSthB4TfBX0SjEnp4Xcb9n5o7hiEw9Y/QRo+aDQsTNy3l2BwGVNPBeB8OYY6OVS7b4oZ3RzVzivAUGDuDTxRKTxr99AqbCAxEvAuUNLKD/GvrC0veRUELlj3npnYbDSzv7748fbMtelwPpD/nVbDs9WnKJVkZ0QaBKgQQLgoQLEbW0U24fU7vW71oumcwsbpQS8xNrW50eZqjnBvJSNsUY6CJbc1LRmAI82qWIIs+2m9qZv+ElVKpSPfzg8lIMzV4874q9pG8nNKKqinloHFavRpQQvWpsDrW3eZYeuKFhwrYGY0S47WE+agbIIH5ppQGESCkZKMje15umzA/il2hy5OEz+IkjIBq78Y9P5e+A/0XY138biz1aSDVN4piHvzw1oqTWKIilLlqsCJLNCl36ZuzS9XERWYCKXjh58 X-Forefront-PRVS: 0035B15214 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(189002)(52314003)(24454002)(199003)(76176999)(97756001)(50466002)(46406003)(50986999)(47776003)(105586002)(83506001)(66066001)(3846002)(2906002)(586003)(7416002)(6116002)(7846002)(23726003)(4326007)(7736002)(8676002)(68736007)(54356999)(101416001)(305945005)(2950100001)(77096005)(15975445007)(1076002)(4001350100001)(81166006)(9686002)(81156014)(97736004)(189998001)(33656002)(92566002)(76506005)(33716001)(110136002)(19580405001)(42186005)(106356001)(19580395003)(18370500001)(2690400003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2250;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR07MB2250;23:ynXoF69wXrcWZyy/UqsmSXuCx41QlA9qg9Ntkqmu9?= =?us-ascii?Q?ALKbe8v1ZcjKtMZ1GOzT7KcDw1PEJ3dPhBRyFk73l34DLjx7qjwam7d4EByX?= =?us-ascii?Q?xzP0ZTscJWjoTnYo9cTk+ZSliPZJr+WkBESZAVgU0z8qBdoJ9b7R6HnCfcm7?= =?us-ascii?Q?SVrv/iDMgmGtHEFWb03WOzDX3m8kVzLgVEMx8F3C5KJCJjISoPeri59GgZXn?= =?us-ascii?Q?Dbqce9unHIh5eSnHUev+L3cuurnihuAq9btJURqjStwtFTcN2QnWdwAu4vzq?= =?us-ascii?Q?nfN7UWERCyTVK3042YwwklqqmE7r8aduxH5yKFLRei71DxLI/x571EJX0r/K?= =?us-ascii?Q?fJijHfBMxsqrFpNY05ALwJdjCP1JMqW8Jf5Ud6DkPYmXZQrCwJ7lyL1Ejpap?= =?us-ascii?Q?kAlwgTIC8aKG4v9c2c74EXWlsZN9xyzd4vtWf3X/Wp25X5CQoSP/13M27ql1?= =?us-ascii?Q?d5MPT2dag8ZVZm3fl3KyR8kauLuw7IuNASEZ5dslNtKT8uz80nT0tadax8NO?= =?us-ascii?Q?lPNsovU/LuGshsI6JLtME+SJAa0+FDusefoS7mbk/EbPDEiU/JGBhls7cbSV?= =?us-ascii?Q?WmrFaIeh+cK8pyxRBEePlaIG5DXK8hXMfGTL+5mGDOc1w6mO6LTGuR8orMJ4?= =?us-ascii?Q?mgg7fSyJCz5hroDp2wJ84wXbjzCe9lgu5DoluNrh01acClu7cHWokgFMPBlY?= =?us-ascii?Q?08NpG6B6NLfx60u2oz/RKNgaV14TbKeOXFvZA0g02HA7Il8B+Mvu99a0ah/y?= =?us-ascii?Q?mYkRxU7nNjgzAH2RsJFgeudznSxHDPrGFyOVh5+bu+0ZHhZZ9AUtjKkCy4ya?= =?us-ascii?Q?sYN7aXTK/+nvvTZxkJ6XoUBPlpRnuoCgawWtJ7dJ8DhFRopFgVStjoibxYaC?= =?us-ascii?Q?nT8R6LPPach01E6JNjgfAmiknOpJKM7jjSAhfN9Vpaa/zqI0ynY7TrPSdLF8?= =?us-ascii?Q?Wuk/rFzcYCYe8AtOz4EH2DqmYBDKnhLvqioatghvPNReEwLmh5tdqfI3mV25?= =?us-ascii?Q?OjhDKGlKuiXMFIPEnjzERr9rqECuVVRdeQtdsVdd7Zyse2eh40T2NBAmPm09?= =?us-ascii?Q?X/Jyazt/voyROMnLDxrjqvtPO7B6Hjj+FJ0TwpfSoRPSQuOjB9xOefngRPFU?= =?us-ascii?Q?7tIZpMB3kGrJdq0/5hWdL0omiNS1PicC4e0LNZLG6MOT073JT3z/i+ZGDRR4?= =?us-ascii?Q?+f76ivu5AAHASnSRgxTFzOoaWfToKcOhof9VXgr/tEBRg8BBO4vGV3XsqSnK?= =?us-ascii?Q?/R/UkI1URQlzL+yJJfRTedNfenFx4AR8oX9NsvaLwskpa6vdfkle1DWRhq3M?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2250;6:W8lnKgApzjmFKK0WnHM5uBNyXcuN/4j+HwN7GH61r4yfx8aN3MFW6Is3tn+kVLkY+MnkgeiE9kcv+IUILWFXkgcGK6wezUMT6Xh7qg6uJCS21Fijp2MmSVZiHvH1Q3VfY/M3xaZsYMpl5HVUt0wvvyVCTGQyKCjARlciIMHJ4iT8S41kqizWJDLC3MAEF08K69Ofbx88yZee0oOHprFgjGEcfXU3dJxm+iU++IRQhsRoOSMab/batiTGp7T85yEDqR8rxo/5Sy5xfSt0y1bMy48INtl6nAY8fxb+Djfi2Ko=;5:Ozr8wafE1y8MbA8auwA94WfrNURycWcQeRx5tLvhsQLOi3vdSdljycZkWzf8NOLKErrk2XE4+jy9LiH9nloilyJmzsG4Ux1P0Oy5PAQkrIbVOys+8ZMBye8xW5L7i5/C1d6xdqt4kqeczmf/CiSQDg==;24:pHiVcLCPViKPtkgiuoczzRuWXdYEX1FDMr7+SJS5SOd7+HQ4Sb8IEB9ZuBeMxWLg5GrHdecxs1pKS6yoVZIpztLv/j5/R+61M361TAiMRiM=;7:2r1dj5YKUlCWEmauu+8bUFT9a3qAYBKn7/RVKN8TZq00wX8psjIp3PaOa89VmJIGQgzFWc7B0/j1RyLeKg6sz7+hGkbLTsCMB5mnjSye3WQMpkKdVzvgpFRSaJ2U+qRCcORZTQZUcvVz+DWay7/8gBnnVf5Zl/flHoVMc4lCYjaLnMxDBvxJA2hwVgIZmrBBBWgchpfqlGFb0ocqrGkhNslQpJGh0nA6KjYlSsJ5k7LTS/qdMDEUklNaiDlg00fQ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2016 14:30:39.3253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2250 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2016 at 09:47:38AM +0200, Andreas Schwab wrote: > Yury Norov writes: > > > The only difference is that non-compat version forces O_LARGEFILE, > > and it should be the default behaviour for all architectures, as > > we don't support 32-bit off_t. The only exception is tile32, that > > continues with compat version of syscalls. > > > > Signed-off-by: Yury Norov > > Acked-by: Arnd Bergmann > > Acked-by: Chris Metcalf [for tile] > > --- > > arch/tile/kernel/compat.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/tile/kernel/compat.c b/arch/tile/kernel/compat.c > > index 4912084..489ae19 100644 > > --- a/arch/tile/kernel/compat.c > > +++ b/arch/tile/kernel/compat.c > > @@ -94,6 +94,9 @@ COMPAT_SYSCALL_DEFINE5(llseek, unsigned int, fd, unsigned int, offset_high, > > #define compat_sys_readahead sys32_readahead > > #define sys_llseek compat_sys_llseek > > > > +#define sys_openat compat_sys_openat > > +#define sys_open_by_handle_at compat_sys_open_by_handle_at > > + > > /* Call the assembly trampolines where necessary. */ > > #define compat_sys_rt_sigreturn _compat_sys_rt_sigreturn > > #define sys_clone _sys_clone > > This is a no-op. Did you mean to add this? Without that the testsuite > of tar fails on ILP32. The change you suggest below is what I originally sent at the end of December, but that chunk was lost after one of numerous rebases probably. http://lkml.iu.edu/hypermail/linux/kernel/1512.3/00510.html IIRC, the only difference between this couple of syscalls and their compat versions is that non-compat syscalls set O_LARGEFILE depending on (BITS_PER_LONG != 32). Next patch of this series introduces ARCH_32BIT_OFF_T config option to force O_LARGEFILE for 64-bit arches, and all new 32-bit arches, as ARCH_32BIT_OFF_T is enabled for existing 32-bit arches explicitly. O_LARGEFILE is controlled like this: -#define force_o_largefile() (BITS_PER_LONG != 32) +#define force_o_largefile() (!IS_ENABLED(CONFIG_ARCH_32BIT_OFF_T)) So if I restore original patch, everything will work. But my question is: if ARCH_32BIT_OFF_T disables O_LARGEFILE for tile32 anyway, what for we redirect native syscall handlers to compat ones? They are looking identical... If my understanding is correct, we can drop the change in arch/tile/kernel/compat.c and join this patch with next one in this series. Chris, Arnd? > > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h > index a26415b..4dcc38d 100644 > --- a/include/uapi/asm-generic/unistd.h > +++ b/include/uapi/asm-generic/unistd.h > @@ -178,7 +178,7 @@ __SYSCALL(__NR_fchownat, sys_fchownat) > #define __NR_fchown 55 > __SYSCALL(__NR_fchown, sys_fchown) > #define __NR_openat 56 > -__SC_COMP(__NR_openat, sys_openat, compat_sys_openat) > +__SYSCALL(__NR_openat, sys_openat) > #define __NR_close 57 > __SYSCALL(__NR_close, sys_close) > #define __NR_vhangup 58 > @@ -676,8 +676,7 @@ __SYSCALL(__NR_fanotify_mark, sys_fanotify_mark) > #define __NR_name_to_handle_at 264 > __SYSCALL(__NR_name_to_handle_at, sys_name_to_handle_at) > #define __NR_open_by_handle_at 265 > -__SC_COMP(__NR_open_by_handle_at, sys_open_by_handle_at, \ > - compat_sys_open_by_handle_at) > +__SYSCALL(__NR_open_by_handle_at, sys_open_by_handle_at) > #define __NR_clock_adjtime 266 > __SC_COMP(__NR_clock_adjtime, sys_clock_adjtime, compat_sys_clock_adjtime) > #define __NR_syncfs 267 > -- > 2.9.0 > > > Andreas. > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different."