From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbcHOOsV (ORCPT ); Mon, 15 Aug 2016 10:48:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58008 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbcHOOsU (ORCPT ); Mon, 15 Aug 2016 10:48:20 -0400 Date: Mon, 15 Aug 2016 16:48:30 +0200 From: Greg KH To: Nadim almas Cc: abbotti@mev.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: android: ion: ion.c: Compression of lines for Message-ID: <20160815144830.GA17399@kroah.com> References: <1470161600-2904-1-git-send-email-nadim.902@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470161600-2904-1-git-send-email-nadim.902@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 11:13:20AM -0700, Nadim almas wrote: > This patch compresses two lines in to a single line in file > ion.c > if immediate return statement is found.It also removes variable > ret as it is no longer needed. > > ne using script Coccinelle. And coccinelle uses following semantic > patch for this compression function: > > @@ > expression e, ret; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Nadim Almas > --- > drivers/staging/android/ion/ion.c | 8 +++----- > > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 52345df..271395b 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle) > { > - int ret; > > - ret = kref_put(&handle->ref, ion_handle_destroy); > - > - return ret; > + return kref_put(&handle->ref, ion_handle_destroy); > } > > static int ion_handle_put(struct ion_handle *handle) > @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle, > return -ENODEV; > } > mutex_unlock(&client->lock); > - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len); > - return ret; > + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len); > } > EXPORT_SYMBOL(ion_phys); Patch is malformed and can not be applied :(