From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932478AbcHOPRs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Aug 2016 11:17:48 -0400
Received: from down.free-electrons.com ([37.187.137.238]:44624 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S932338AbcHOPRp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Aug 2016 11:17:45 -0400
Date: Mon, 15 Aug 2016 17:17:42 +0200
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        linux-mtd@lists.infradead.org,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org,
        Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
        Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH 1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips
Message-ID: <20160815171742.3b5d1fb6@bbrezillon>
In-Reply-To: <1465914067-29736-1-git-send-email-boris.brezillon@free-electrons.com>
References: <1465914067-29736-1-git-send-email-boris.brezillon@free-electrons.com>
Organization: Free Electrons
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 14 Jun 2016 16:21:06 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> ONFI 4.0 spec defines different values for the tADL_min timing.
> Since we don't want to have different timings depending on the ONFI
> version, we just set tADL_min to the maximum value (the one specified
> in the ONFI 4.0 spec).

Applied both.

> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>  drivers/mtd/nand/nand_timings.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
> index e81470a..c0941d5 100644
> --- a/drivers/mtd/nand/nand_timings.c
> +++ b/drivers/mtd/nand/nand_timings.c
> @@ -16,7 +16,7 @@
>  static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	/* Mode 0 */
>  	{
> -		.tADL_min = 200000,
> +		.tADL_min = 400000,
>  		.tALH_min = 20000,
>  		.tALS_min = 50000,
>  		.tAR_min = 25000,
> @@ -53,7 +53,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 1 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 10000,
>  		.tALS_min = 25000,
>  		.tAR_min = 10000,
> @@ -90,7 +90,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 2 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 10000,
>  		.tALS_min = 15000,
>  		.tAR_min = 10000,
> @@ -127,7 +127,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 3 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,
> @@ -164,7 +164,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 4 */
>  	{
> -		.tADL_min = 70000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,
> @@ -201,7 +201,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 5 */
>  	{
> -		.tADL_min = 70000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,