Hi Marcel, On Tue, Aug 16, 2016 at 10:10:07AM +0200, Marcel Holtmann wrote: > > diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h > > index a7d67aec3632..314b243df996 100644 > > --- a/drivers/bluetooth/hci_uart.h > > +++ b/drivers/bluetooth/hci_uart.h > > @@ -35,7 +35,7 @@ > > #define HCIUARTGETFLAGS _IOR('U', 204, int) > > > > /* UART protocols */ > > -#define HCI_UART_MAX_PROTO 10 > > +#define HCI_UART_MAX_PROTO 11 > > > > #define HCI_UART_H4 0 > > #define HCI_UART_BCSP 1 > > @@ -47,6 +47,7 @@ > > #define HCI_UART_BCM 7 > > #define HCI_UART_QCA 8 > > #define HCI_UART_AG6XX 9 > > +#define HCI_UART_NOKIA 10 > > since it seems the driver is getting closer to be ready, > lets merge this extra protocol identifier as a separate patch. depends on the definition of "the driver". It requires the gpio information from DT, so it depends on the new serial bus. I still have to implement that and it has the potential to trigger a bit of discussion :) Anyways I will split this out into its own patch later. > Then we can adapt btattach as well for it. It's enough to set ldisc=N_HCI and proto=HCI_UART_NOKIA. Everything else is done by the protocol driver. I still think it should be done from the kernel and will try to come up with something in the serial bus. -- Sebastian