From: Mark Rutland <mark.rutland@arm.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos: Use stdout non-deprecated property and add serial options to Odroid XU/XU3/XU4
Date: Wed, 17 Aug 2016 11:39:35 +0100 [thread overview]
Message-ID: <20160817103935.GE30900@leverpostej> (raw)
In-Reply-To: <bae50bce-8e56-62cc-89b4-68532c2acaf0@samsung.com>
On Wed, Aug 17, 2016 at 12:28:48PM +0200, Krzysztof Kozlowski wrote:
> On 08/17/2016 12:25 PM, Mark Rutland wrote:
> > On Wed, Aug 17, 2016 at 09:34:58AM +0200, Krzysztof Kozlowski wrote:
> >> The "linux,stdout-path" is deprecated.
> >>
> >> Add serial options so the console can be properly configured when
> >> bootloader does not pass "console" parameter to command line. Without
> >> options and lack of "console", the serial output dies during boot (just
> >> after probing sound).
> >
> > I'm confused. Is this just a cleanup (given "linux,stdout-path" is
> > deprecated but still supported), or a bug fix?
>
> There is no bug, so rather this is cleanup and improvement in one.
> Usually we pass full console=ttySAC2,115200n8 from UBoot to command
> line. The usage of serial options allows skipping that.
>
> I can split the cleanup part from improvement. To me it looked a little
> bit too much but I don't mind.
No need. It just wasn't clear to me that you had U-Boot configured to
pass the rate on the command line.
As I mentioned, I suspect that the serial output doesn't "die" as such,
but rather changes rate. It might be worth clarifying that in the commit
message, but either way the patch itself is fine, and it's no big deal.
Thanks,
Mark.
next prev parent reply other threads:[~2016-08-17 10:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 7:34 [PATCH] ARM: dts: exynos: Use stdout non-deprecated property and add serial options to Odroid XU/XU3/XU4 Krzysztof Kozlowski
2016-08-17 10:25 ` Mark Rutland
2016-08-17 10:28 ` Krzysztof Kozlowski
2016-08-17 10:39 ` Mark Rutland [this message]
2016-08-17 15:23 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817103935.GE30900@leverpostej \
--to=mark.rutland@arm.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).