From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbcHQRPx (ORCPT ); Wed, 17 Aug 2016 13:15:53 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:33992 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbcHQRPw (ORCPT ); Wed, 17 Aug 2016 13:15:52 -0400 Date: Wed, 17 Aug 2016 18:15:46 +0100 From: Al Viro To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org Subject: Re: [PATCH 1/2] ia64: macro-ize ia64_done_with_exception in asm/uaccess.h Message-ID: <20160817171546.GD2356@ZenIV.linux.org.uk> References: <20160816151443.31082-1-paul.gortmaker@windriver.com> <20160816151443.31082-2-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160816151443.31082-2-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 11:14:42AM -0400, Paul Gortmaker wrote: > Most of the other C content in this file is already implemented > in macro form. Doing the same for this function will allow us > to get rid of the duplicated search_exception_tables prototype. > We will bring it in as required via inclusion. What is it doing in uaccess.h in the first place? ia64_done_with_exception() is used only in the guts of arch/ia64 (2 in kernel, 1 in mm), so why dump it into a widely-used header?