From: Al Viro <viro@ZenIV.linux.org.uk>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
riel@surriel.com, akpm@linux-foundation.org,
vdavydov@virtuozzo.com, mhocko@suse.com, vbabka@suse.cz,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
bywxiaobai@163.com
Subject: Re: [PATCH v2 2/2] fs: super.c: Add tracepoint to get name of superblock shrinker
Date: Thu, 18 Aug 2016 07:32:39 +0100 [thread overview]
Message-ID: <20160818063239.GO2356@ZenIV.linux.org.uk> (raw)
In-Reply-To: <600943d0701ae15596c36194684453fef9ee075e.1471496833.git.janani.rvchndrn@gmail.com>
On Thu, Aug 18, 2016 at 02:09:31AM -0400, Janani Ravichandran wrote:
> static LIST_HEAD(super_blocks);
> @@ -64,6 +65,7 @@ static unsigned long super_cache_scan(struct shrinker *shrink,
> long inodes;
>
> sb = container_of(shrink, struct super_block, s_shrink);
> + trace_mm_shrinker_callback(shrink, sb->s_type->name);
IOW, we are (should that patch be accepted) obliged to keep the function in
question and the guts of struct shrinker indefinitely.
NAK. Keep your debugging patches in your tree and maintain them yourself.
And if a change in the kernel data structures breaks them (and your userland
code relying on those), it's your problem.
Tracepoints are very nice for local debugging/data collection/etc. patches.
Accepting them into mainline shifts the responsibility for updating them
to the rest of us, and unlike you we can't update the userland side.
Adding a userland ABI means pledging to keep it alive pretty much indefinitely.
It's not automatically unacceptable (hell, new syscalls get added from time
to time), but it should come with a serious analysis of what's getting exposed
and it shouldn't be accepted without such.
next prev parent reply other threads:[~2016-08-18 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 5:33 [PATCH v2 0/2] Get callbacks/names of shrinkers from tracepoints Janani Ravichandran
2016-08-18 5:38 ` [PATCH v2 1/2] include: trace: Display names of shrinker callbacks Janani Ravichandran
2016-08-18 6:09 ` [PATCH v2 2/2] fs: super.c: Add tracepoint to get name of superblock shrinker Janani Ravichandran
2016-08-18 6:32 ` Al Viro [this message]
2016-08-18 6:40 ` Michal Hocko
2016-08-18 13:22 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818063239.GO2356@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bywxiaobai@163.com \
--cc=janani.rvchndrn@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).