From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 1/2] usb: USB Type-C connector class
Date: Thu, 18 Aug 2016 13:44:56 +0300 [thread overview]
Message-ID: <20160818104456.GW9927@kuha.fi.intel.com> (raw)
In-Reply-To: <20160817175840.GA4764@roeck-us.net>
On Wed, Aug 17, 2016 at 10:58:40AM -0700, Guenter Roeck wrote:
> On Wed, Aug 17, 2016 at 01:34:40PM +0300, Heikki Krogerus wrote:
> > The purpose of USB Type-C connector class is to provide
> > unified interface for the user space to get the status and
> > basic information about USB Type-C connectors on a system,
> > control over data role swapping, and when the port supports
> > USB Power Delivery, also control over power role swapping
> > and Alternate Modes.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > ---
> [ ... ]
>
> > +
> > +static ssize_t current_power_role_store(struct device *dev,
> > + struct device_attribute *attr,
> > + const char *buf, size_t size)
> > +{
> > + struct typec_port *port = to_typec_port(dev);
> > + enum typec_role role;
> > + int ret = size;
> > +
> > + if (!port->cap->usb_pd) {
> > + dev_dbg(dev, "power role swap only supported with USB PD\n");
> > + return -EOPNOTSUPP;
> > + }
> > +
> > + if (!port->cap->pr_set) {
> > + dev_dbg(dev, "power role swapping not supported\n");
> > + return -EOPNOTSUPP;
> > + }
> > +
> > + if (port->pwr_opmode != TYPEC_PWR_MODE_PD) {
> > + dev_dbg(dev, "partner unable to swap power role\n");
> > + return -EIO;
> > + }
> > +
> > + if (!port->connected)
> > + return size;
> > +
> > + ret = sysfs_strmatch(typec_roles, ARRAY_SIZE(typec_roles), buf);
> > + if (ret < 0)
> > + return ret;
> > +
> > + role = ret;
> > +
> > + ret = port->cap->pr_set(port->cap, role);
>
> if (ret)
> missing.
It also seems to be missing from current_vconn_role_store().. How have
I managed to do that?
Thanks for catching this.
--
heikki
next prev parent reply other threads:[~2016-08-18 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 10:34 [PATCH v5 0/2] USB Type-C Connector class Heikki Krogerus
2016-08-17 10:34 ` [PATCH v5 1/2] usb: USB Type-C connector class Heikki Krogerus
2016-08-17 13:14 ` Frans Klaver
2016-08-17 13:53 ` Heikki Krogerus
2016-08-17 14:00 ` Frans Klaver
2016-08-17 13:30 ` Guenter Roeck
2016-08-17 13:56 ` Heikki Krogerus
2016-08-17 17:53 ` Guenter Roeck
2016-08-18 10:43 ` Heikki Krogerus
2016-08-17 17:58 ` Guenter Roeck
2016-08-18 10:44 ` Heikki Krogerus [this message]
2016-08-17 10:34 ` [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
2016-08-17 12:53 ` Felipe Balbi
2016-08-17 13:32 ` Heikki Krogerus
2016-08-17 23:00 ` Peter Chen
2016-08-18 6:33 ` Felipe Balbi
2016-08-18 13:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818104456.GW9927@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).