Re: [PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values

[Russell King - ARM Linux <linux@armlinux.org.uk>]

On Thu, Aug 18, 2016 at 03:34:12PM +0100, Jose Abreu wrote:
> Colorspace and scan information values were being written in wrong
> offsets. This patch corrects this and writes the values at the
> offsets specified in the databook.
> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

Thanks.

> ---
>  drivers/gpu/drm/bridge/dw-hdmi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index 77ab473..cdf39aa 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -940,10 +940,11 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
>  	 */
>  
>  	/*
> -	 * AVI data byte 1 differences: Colorspace in bits 4,5 rather than 5,6,
> -	 * active aspect present in bit 6 rather than 4.
> +	 * AVI data byte 1 differences: Colorspace in bits 0,1 rather than 5,6,
> +	 * scan info in bits 4,5 rather than 0,1 and active aspect present in
> +	 * bit 6 rather than 4.
>  	 */
> -	val = (frame.colorspace & 3) << 4 | (frame.scan_mode & 0x3);
> +	val = (frame.scan_mode & 3) << 4 | (frame.colorspace & 3);
>  	if (frame.active_aspect & 15)
>  		val |= HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT;
>  	if (frame.top_bar || frame.bottom_bar)
> -- 
> 2.1.4
> 

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.