From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Corentin LABBE <clabbe.montjoie@gmail.com>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare Spinlock
Date: Thu, 18 Aug 2016 12:44:43 -0700 [thread overview]
Message-ID: <20160818194443.GX26240@tuxbot> (raw)
In-Reply-To: <0a17ceec-13f7-ddeb-69dd-2505154e8ccf@gmail.com>
On Thu 18 Aug 12:38 PDT 2016, Corentin LABBE wrote:
> Hello
>
> Thanks for your review, I will fix all your reports for next version.
>
> On 12/08/2016 21:06, Bjorn Andersson wrote:
> > On Fri 12 Aug 04:46 PDT 2016, LABBE Corentin wrote:
> >
> >> Add hwspinlock support for the Allwinner Hardware Spinlock device
> >> present on the A83T, H3 and A64 SoCs.
> >>
> >> This Hardware Spinlock device provides hardware assistance
> >> for synchronization between the multiple processors in the system.
> >>
> > [..]
> >> + goto clk_fail;
> >> + }
> >> +
> >> + dev_info(&pdev->dev, "Sun8i hwspinlock driver loaded with %d locks\n",
> >> + priv->num_locks);
> >
> > Please don't advertise the driver on success.
> >
>
> I was doing that because datasheet specify only 32 slot, but later a register give a possibility of more slots.
> Perhaps its better to advertise only for uncommon hardware (slot > 32) ?
>
I see, well that would be useful for developers to see, how about you
just make it dev_dbg? That way one would be a command line addition [1]
away from getting the information out.
[1] dyndbg="module sun8i_hwspinlock +p"
Regards,
Bjorn
prev parent reply other threads:[~2016-08-19 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 11:46 [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare Spinlock LABBE Corentin
2016-08-12 11:46 ` [PATCH RFC 2/3] Documentation: dt: add the sun8i-hwspinlock bindings document LABBE Corentin
2016-08-12 11:46 ` [PATCH RFC 3/3] ARM: dts: sun8i: add hwspinlock device to sun8i-h3 LABBE Corentin
2016-08-12 11:49 ` [linux-sunxi] " Hans de Goede
2016-08-12 19:06 ` [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare Spinlock Bjorn Andersson
2016-08-18 19:38 ` Corentin LABBE
2016-08-18 19:44 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818194443.GX26240@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=clabbe.montjoie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).