From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323AbcHSPEy (ORCPT ); Fri, 19 Aug 2016 11:04:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754689AbcHSPEw (ORCPT ); Fri, 19 Aug 2016 11:04:52 -0400 Date: Fri, 19 Aug 2016 17:04:06 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Suravee Suthikulpanit Cc: joro@8bytes.org, pbonzini@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sherry.hurwitz@amd.com Subject: Re: [PART2 PATCH v6 12/12] svm: Implements update_pi_irte hook to setup posted interrupt Message-ID: <20160819150405.GA5282@potion> References: <1471549364-6672-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1471549364-6672-13-git-send-email-Suravee.Suthikulpanit@amd.com> <20160819144907.GB1885@potion> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160819144907.GB1885@potion> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 19 Aug 2016 15:04:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-08-19 16:49+0200, Radim Krčmář: > Minor design note: > To make the usage of "struct amd_ir_data" safer, we could pass "struct > list_head" into irq_set_vcpu_affinity(), instead of returning "struct > amd_ir_data *". > > irq_set_vcpu_affinity() would add "struct amd_ir_data" to the list only > if ir_data was not already in some list and report whether the list > was modified. No, this would not simplify the search. An important point of list_head in amd_ir_data was to let us know the current list.