From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753580AbcHUUQW (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 Aug 2016 16:16:22 -0400
Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:33134 "EHLO
        Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753281AbcHUUQU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 Aug 2016 16:16:20 -0400
Date: Sun, 21 Aug 2016 22:16:16 +0200
From: Florian Westphal <fw@strlen.de>
To: Willy Tarreau <w@1wt.eu>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Florian Westphal <fw@strlen.de>,
        Pablo Neira Ayuso <pablo@netfilter.org>, Jay <MyMailClone@t-online.de>
Subject: Re: [PATCH 3.10 007/180] netfilter: x_tables: validate targets of
 jumps
Message-ID: <20160821201616.GA23675@breakpoint.cc>
References: <1471793510-13022-1-git-send-email-w@1wt.eu>
 <1471793510-13022-8-git-send-email-w@1wt.eu>
 <20160821195752.GA21254@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160821195752.GA21254@1wt.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Willy Tarreau <w@1wt.eu> wrote:
> On Sun, Aug 21, 2016 at 05:28:57PM +0200, Willy Tarreau wrote:
> > From: Florian Westphal <fw@strlen.de>
> > 
> > commit 36472341017529e2b12573093cc0f68719300997 upstream.
> > 
> > When we see a jump also check that the offset gets us to beginning of
> > a rule (an ipt_entry).
> (...)
> 
> Sorry, this patch is bad and causes performance issues, I didn't notice
> that 3.14 had a different version, below. Thanks to Jay for reporting
> the problem to me. I'll push 3.10.103-rc2 after some cool down period.

Please either hold this one back or also queue
commit f4dc77713f8016d2e8a3295e1c9c53a21f296def
netfilter: x_tables: speed up jump target validation

It supersedes this one.

> +static bool find_jump_target(const struct xt_table_info *t,
> +			     const void *entry0,
> +			     const struct arpt_entry *target)
> +{
> +	struct arpt_entry *iter;
> +
> +	xt_entry_foreach(iter, entry0, t->size) {
> +		 if (iter == target)
> +			return true;
> +	}

This linear search works but its too slow with large rule sets.