From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753822AbcHVBlT (ORCPT ); Sun, 21 Aug 2016 21:41:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36418 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbcHVBlR (ORCPT ); Sun, 21 Aug 2016 21:41:17 -0400 Date: Mon, 22 Aug 2016 04:41:11 +0300 From: "Michael S. Tsirkin" To: SF Markus Elfring Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jason Wang , Mike Rapoport , Paolo Abeni , Soheil Hassas Yeganeh , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 2/2] tun: Rename a jump label in update_filter() Message-ID: <20160822044048-mutt-send-email-mst@kernel.org> References: <566ABCD9.1060404@users.sourceforge.net> <9cf06275-924d-6c22-d8a8-f733a03cca23@users.sourceforge.net> <0c8d93e2-34cf-ca23-955e-999f424b3ab2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c8d93e2-34cf-ca23-955e-999f424b3ab2@users.sourceforge.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 22 Aug 2016 01:41:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 20, 2016 at 09:37:16AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 09:00:34 +0200 > > Adjust a jump target according to the Linux coding style convention. > > Signed-off-by: Markus Elfring I don't have an opinion of this one. Which convention do you refer to? > --- > drivers/net/tun.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index a1aeccb..e249428 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -753,7 +753,7 @@ static int update_filter(struct tap_filter *filter, void __user *arg) > for (; n < uf.count; n++) { > if (!is_multicast_ether_addr(addr[n].u)) { > err = 0; /* no filter */ > - goto done; > + goto free_addr; > } > addr_hash_set(filter->mask, addr[n].u); > } > @@ -769,8 +769,7 @@ static int update_filter(struct tap_filter *filter, void __user *arg) > > /* Return the number of exact filters */ > err = nexact; > - > -done: > +free_addr: > kfree(addr); > return err; > } > -- > 2.9.3