From: Peter Chen <hzpeterchen@gmail.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: chipidea: support generic phy in PM code path
Date: Mon, 22 Aug 2016 15:29:07 +0800 [thread overview]
Message-ID: <20160822072907.GD4362@shlinux2> (raw)
In-Reply-To: <20160822143921.36b6f95a@xhacker>
On Mon, Aug 22, 2016 at 02:39:21PM +0800, Jisheng Zhang wrote:
> Hi Peter,
>
> On Mon, 22 Aug 2016 13:33:08 +0800 Peter Chen wrote:
>
> > On Fri, Aug 19, 2016 at 08:10:13PM +0800, Jisheng Zhang wrote:
> > > Support generic phy in PM code path: call phy_power_off/phy_power_on
> > > in ci_controller_suspend/ci_controller_resume.
> > >
> > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > > ---
> > > drivers/usb/chipidea/core.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > > index ae12595..ef9fb0b 100644
> > > --- a/drivers/usb/chipidea/core.c
> > > +++ b/drivers/usb/chipidea/core.c
> > > @@ -1116,6 +1116,7 @@ static void ci_controller_suspend(struct ci_hdrc *ci)
> > > usleep_range(ci->platdata->phy_clkgate_delay_us,
> > > ci->platdata->phy_clkgate_delay_us + 50);
> > > usb_phy_set_suspend(ci->usb_phy, 1);
> > > + phy_power_off(ci->phy);
> >
> > How could you support USB wakeup after PHY is powered off?
>
> Per my understanding, the PHY's power off just power off data communication part
> but leaves the circuits involved in wakeup detection active.
>
Ok, I hope so.
Peter
>
> >
> > Peter
> >
> > > ci->in_lpm = true;
> > > enable_irq(ci->irq);
> > > }
> > > @@ -1132,9 +1133,10 @@ static int ci_controller_resume(struct device *dev)
> > > }
> > >
> > > ci_hdrc_enter_lpm(ci, false);
> > > - if (ci->usb_phy) {
> > > + if (ci->usb_phy || ci->phy) {
> > > usb_phy_set_suspend(ci->usb_phy, 0);
> > > usb_phy_set_wakeup(ci->usb_phy, false);
> > > + phy_power_on(ci->phy);
> > > hw_wait_phy_stable();
> > > }
> > >
> > > --
> > > 2.9.3
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-08-22 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 12:10 [PATCH] usb: chipidea: support generic phy in PM code path Jisheng Zhang
2016-08-22 5:33 ` Peter Chen
2016-08-22 6:39 ` Jisheng Zhang
2016-08-22 7:29 ` Peter Chen [this message]
2016-08-22 8:14 ` Jisheng Zhang
2016-08-22 8:23 ` Kishon Vijay Abraham I
2016-08-22 8:29 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822072907.GD4362@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).