From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932727AbcHVTmJ (ORCPT ); Mon, 22 Aug 2016 15:42:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42952 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932444AbcHVTmH (ORCPT ); Mon, 22 Aug 2016 15:42:07 -0400 Date: Mon, 22 Aug 2016 22:31:46 +0300 From: "Michael S. Tsirkin" To: Dan Carpenter Cc: Jonathan Corbet , linux-kernel@vger.kernel.org, Julia Lawall , Jason Wang , linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] CodingStyle: add some more error handling guidelines Message-ID: <20160822222900-mutt-send-email-mst@kernel.org> References: <1471874251-7721-1-git-send-email-mst@redhat.com> <20160822081617.386db8cd@lwn.net> <20160822174355-mutt-send-email-mst@kernel.org> <20160822185006.GF4129@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160822185006.GF4129@mwanda> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 22 Aug 2016 19:31:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2016 at 09:50:06PM +0300, Dan Carpenter wrote: > On Mon, Aug 22, 2016 at 05:53:02PM +0300, Michael S. Tsirkin wrote: > > The point is really naming label for the part of init that failed > > (and so needs to be skipped), rather than the part that will run. > > Naming labels after what "needs to be skipped" doesn't work. How does > that meaning make sense for err_cgroup in vhost_dev_set_owner()? What > needs to be skipped here? > > regards, > dan carpenter Nothing because we are destroying the thread, so we don't need to detach it. I guess I'm convinced it's not very consistent at this point. -- MST