From: Stephen Boyd <sboyd@codeaurora.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
linux@armlinux.org.uk, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: dts: Add MDM9615 dtsi
Date: Mon, 22 Aug 2016 17:51:19 -0700 [thread overview]
Message-ID: <20160823005119.GO6502@codeaurora.org> (raw)
In-Reply-To: <884c47cb-6629-fab6-fba0-d189ea835adb@baylibre.com>
On 08/20, Neil Armstrong wrote:
> On 08/18/2016 08:08 PM, Stephen Boyd wrote:
> > On 08/18, Neil Armstrong wrote:
> >
> >
> >> +
> >> + gsbi2: gsbi@16100000 {
> >> + compatible = "qcom,gsbi-v1.0.0";
> >> + cell-index = <2>;
> >> + reg = <0x16100000 0x100>;
> >> + clocks = <&gcc GSBI2_H_CLK>;
> >> + clock-names = "iface";
> >> + status = "disabled";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + ranges;
> >> +
> >> + gsbi2_i2c: i2c@16180000 {
> >> + compatible = "qcom,i2c-qup-v1.1.1";
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + reg = <0x16180000 0x1000>;
> >> + interrupts = <GIC_SPI 149 IRQ_TYPE_NONE>;
> >
> > There should be a trigger type... high perhaps?
>
> Well, I do not know, and other qcom dtsi has 0x0 or NONE here...
We should fix those. The driver uses IRQF_TRIGGER_HIGH so it
seems like we should put that here as well.
>
> >
> >> +
> >> + clocks = <&gcc GSBI2_QUP_CLK>, <&gcc GSBI2_H_CLK>;
> >> + clock-names = "core", "iface";
> >> + status = "disabled";
> >> + };
> >> + };
> >> +
> >> +
> >> + qcom,ssbi@500000 {
> >> + compatible = "qcom,ssbi";
> >> + reg = <0x500000 0x1000>;
> >> + qcom,controller-type = "pmic-arbiter";
> >> +
> >> + pmicintc: pmic@0 {
> >> + compatible = "qcom,pm8018", "qcom,pm8921";
> >
> > I know that DT specifies most specific compatible first, but when
> > the generic compatible is part number specific as well it never
> > feels right to me. I guess I'll have to get over this.
> >
> >> + interrupts = <GIC_PPI 226 IRQ_TYPE_NONE>;
> >> + #interrupt-cells = <2>;
> >> + interrupt-controller;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >
> > Can we have interrupt-parent = <&pmicintc> here instead of in
> > every node?
>
> No since the pmic node interrupt parent is the GIC.
Ah ok. Silly me.
> >
> >> + compatible = "qcom,bam-v1.3.0";
> >> + reg = <0x12142000 0x8000>;
> >> + interrupts = <GIC_SPI 97 IRQ_TYPE_NONE>;
> >
> > There should really be some flags.
>
> Same as for the qup and uartdm, other qcom dtsi left 0x0 or NONE here...
The driver uses IRQF_TRIGGER_HIGH here, so use that in dtsi?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-23 0:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 13:07 [PATCH v2 0/2] ARM: dts: Add support for the MDM9615 Neil Armstrong
2016-08-18 13:07 ` [PATCH v2 1/2] ARM: dts: Add MDM9615 dtsi Neil Armstrong
2016-08-18 18:08 ` Stephen Boyd
2016-08-20 18:07 ` Neil Armstrong
2016-08-23 0:51 ` Stephen Boyd [this message]
2016-08-18 13:07 ` [PATCH v2 2/2] dt-bindings: qcom: Add MDM9615 bindings Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823005119.GO6502@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).