From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757031AbcHWAzR (ORCPT ); Mon, 22 Aug 2016 20:55:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36391 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755476AbcHWAzP (ORCPT ); Mon, 22 Aug 2016 20:55:15 -0400 Date: Mon, 22 Aug 2016 17:55:12 -0700 From: Stephen Boyd To: Chanwoo Choi Cc: s.nawrocki@samsung.com, tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org, k.kozlowski@samsung.com, chanwoo@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section Message-ID: <20160823005512.GP6502@codeaurora.org> References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/22, Chanwoo Choi wrote: > This patch moves the all samsung_cmu_info struct to initconst section > because they are used only in initconst section. > > Signed-off-by: Chanwoo Choi > --- > drivers/clk/samsung/clk-exynos5260.c | 350 +++++++++++++++++------------------ > 1 file changed, 175 insertions(+), 175 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5260.c b/drivers/clk/samsung/clk-exynos5260.c > index a43642c36039..fd1d9bfc151b 100644 > --- a/drivers/clk/samsung/clk-exynos5260.c > +++ b/drivers/clk/samsung/clk-exynos5260.c > @@ -131,21 +131,21 @@ static const struct samsung_gate_clock aud_gate_clks[] __initconst = { > EN_IP_AUD, 4, 0, 0), > }; > > +static const struct samsung_cmu_info aud_cmu __initconst = { > + .mux_clks = aud_mux_clks, > + .nr_mux_clks = ARRAY_SIZE(aud_mux_clks), > + .div_clks = aud_div_clks, > + .nr_div_clks = ARRAY_SIZE(aud_div_clks), > + .gate_clks = aud_gate_clks, > + .nr_gate_clks = ARRAY_SIZE(aud_gate_clks), > + .nr_clk_ids = AUD_NR_CLK, > + .clk_regs = aud_clk_regs, > + .nr_clk_regs = ARRAY_SIZE(aud_clk_regs), > +}; > + > static void __init exynos5260_clk_aud_init(struct device_node *np) > { > - struct samsung_cmu_info cmu = { NULL }; > - I presume this was done this way to save some initdata space by only allocating the array that's needed at runtime? I would expect to see some more kernel image bloat from this change but runtime memory usage would stay the same. Is there any real benefit from this patch though? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project