From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757297AbcHWIBy (ORCPT ); Tue, 23 Aug 2016 04:01:54 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36177 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755746AbcHWIBv (ORCPT ); Tue, 23 Aug 2016 04:01:51 -0400 Date: Tue, 23 Aug 2016 09:44:08 +0200 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 01/22] usb: serial: ti_usb_3410_5052: Do not use __uX types Message-ID: <20160823074408.GA16896@localhost> References: <20160726180002.2398-1-m.othacehe@gmail.com> <20160726180002.2398-2-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160726180002.2398-2-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 07:59:41PM +0200, Mathieu OTHACEHE wrote: > __uX types should only be used for user-space interactions. > > Signed-off-by: Mathieu OTHACEHE > --- > > Changelog: > v2: > * Replace cpu_to_be16s calls by cpu_to_be16 > * Remove other useless casts You should have mentioned this in the commit message as well (i.e. that you're doing more than just replacing __uX types). > drivers/usb/serial/ti_usb_3410_5052.c | 101 +++++++++++++++++----------------- > 1 file changed, 51 insertions(+), 50 deletions(-) > > diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c > index 07b4bf0..ebeea51 100644 > static int ti_do_download(struct usb_device *dev, int pipe, > - u8 *buffer, int size) > + u8 *buffer, int size) > { > int pos; > u8 cs = 0; I dropped this unrelated change, and amended the commit message before applying. Thanks, Johan