From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757202AbcHWHwG (ORCPT ); Tue, 23 Aug 2016 03:52:06 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34070 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbcHWHwE (ORCPT ); Tue, 23 Aug 2016 03:52:04 -0400 Date: Tue, 23 Aug 2016 09:52:01 +0200 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 02/22] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages Message-ID: <20160823075201.GB16896@localhost> References: <20160726180002.2398-1-m.othacehe@gmail.com> <20160726180002.2398-3-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160726180002.2398-3-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 07:59:42PM +0200, Mathieu OTHACEHE wrote: > Remove useless or redundant dev_dbg messages. > Fix debug-message typos. You never fix any typos, and forgot to mention the added NULL-check for oldtermios, which is currently not needed and really should go in its own patch. > Signed-off-by: Mathieu OTHACEHE > --- > Changelog: > v2: > * Keep some debug messages > > drivers/usb/serial/ti_usb_3410_5052.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-) > @@ -967,9 +956,15 @@ static void ti_set_termios(struct tty_struct *tty, > cflag = tty->termios.c_cflag; > iflag = tty->termios.c_iflag; > > - dev_dbg(&port->dev, "%s - cflag %08x, iflag %08x\n", __func__, cflag, iflag); > - dev_dbg(&port->dev, "%s - old clfag %08x, old iflag %08x\n", __func__, > - old_termios->c_cflag, old_termios->c_iflag); > + dev_dbg(&port->dev, > + "%s - cflag 0x%08x, iflag 0x%08x\n", __func__, cflag, iflag); > + > + if (old_termios) { > + dev_dbg(&port->dev, "%s - old clfag 0x%08x, old iflag 0x%08x\n", Notice that "clfag" is still misspelled. > + __func__, > + old_termios->c_cflag, > + old_termios->c_iflag); > + } > > if (tport == NULL) > return; So, I dropped this chunk, and applied the rest. Thanks, Johan