linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Russ Dill <Russ.Dill@ti.com>, Dave Gerlach <d-gerlach@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	"Andrew F . Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>,
	Tero Kristo <t-kristo@ti.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 5/5] firmware: ti_sci: Add support for reboot core service
Date: Tue, 23 Aug 2016 12:48:41 -0500	[thread overview]
Message-ID: <20160823174841.GA23677@rob-hp-laptop> (raw)
In-Reply-To: <20160819225159.10758-6-nm@ti.com>

On Fri, Aug 19, 2016 at 05:51:59PM -0500, Nishanth Menon wrote:
> Since system controller now has control over SoC power management, it
> needs to be explicitly requested to reboot the SoC. Add support for
> it.
> 
> In some systems however, SoC needs to toggle a GPIO or send event to an
> external entity (like a PMIC) for a system reboot to take place. To
> facilitate that, we allow for a DT property to determine if the reboot
> handler will be registered and further, the service is also made
> available to other drivers (such as PMIC driver) to sequence the
> additional operation and trigger the SoC reboot as the last step.
> 
> Tested-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  .../devicetree/bindings/arm/keystone/ti,sci.txt    |  1 +
>  drivers/firmware/ti_sci.c                          | 85 ++++++++++++++++++++++
>  drivers/firmware/ti_sci.h                          | 12 +++
>  include/linux/soc/ti/ti_sci_protocol.h             | 11 +++
>  4 files changed, 109 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt b/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
> index 965d45e313b1..ed5b8fc185f1 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
> @@ -38,6 +38,7 @@ Optional Properties:
>  - reg-names:
>  	debug_messages - Map the Debug message region
>  - reg:  register space corresponding to the debug_messages
> +- ti,system-reboot-controller: If system reboot can be triggered by SoC reboot

Don't define bindings incrementally. But all the binding in one patch.

Rob

  reply	other threads:[~2016-08-23 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 22:51 [PATCH 0/5] firmware: Add support for TI System Control Interface (TI-SCI) protocol driver Nishanth Menon
2016-08-19 22:51 ` [PATCH 1/5] Documentation: Add support for TI System Control Interface (TI-SCI) protocol Nishanth Menon
2016-08-19 22:51 ` [PATCH 2/5] firmware: Add basic " Nishanth Menon
2016-08-21 16:20   ` Lokesh Vutla
2016-08-23 18:38     ` Nishanth Menon
2016-08-19 22:51 ` [PATCH 3/5] firmware: ti_sci: Add support for Device control Nishanth Menon
2016-08-22  3:56   ` Lokesh Vutla
2016-08-23 18:45     ` Nishanth Menon
2016-08-29 22:30       ` Santosh Shilimkar
2016-08-19 22:51 ` [PATCH 4/5] firmware: ti_sci: Add support for Clock control Nishanth Menon
2016-08-19 22:51 ` [PATCH 5/5] firmware: ti_sci: Add support for reboot core service Nishanth Menon
2016-08-23 17:48   ` Rob Herring [this message]
2016-08-23 18:46     ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823174841.GA23677@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=Russ.Dill@ti.com \
    --cc=afd@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=s-anna@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).