From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755880AbcHWUtZ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Aug 2016 16:49:25 -0400
Received: from mail.kernel.org ([198.145.29.136]:55444 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753600AbcHWUtW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Aug 2016 16:49:22 -0400
Date: Tue, 23 Aug 2016 15:48:27 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Jingoo Han <jingoohan1@gmail.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Kukjin Kim <kgene@kernel.org>, Ley Foon Tan <lftan@altera.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Pratyush Anand <pratyush.anand@gmail.com>,
        Richard Zhu <Richard.Zhu@freescale.com>,
        Tom Long Nguyen <tom.l.nguyen@intel.com>,
        Will Deacon <will.deacon@arm.com>, rfi@lists.rocketboards.org,
        linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 0/8] PCI: more trivial demodularization of builtin code
Message-ID: <20160823204827.GA5838@localhost>
References: <20160822215948.27251-1-paul.gortmaker@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160822215948.27251-1-paul.gortmaker@windriver.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 22, 2016 at 05:59:40PM -0400, Paul Gortmaker wrote:
> This is another group of commits that was chosen since they really don't
> change anything even at a binary object file level ; they just replace
> module_init with device_initcall (which are identical), and remove some
> MODULE_<blah> tags that are no-ops in code.  So the run time regression
> risk is zero here.
> 
> More specifically, we are doing the following to these PCI files that
> currently can only be built-in:
> 
>  -- remove the include of module.h ; replace it with init.h as req'd
> 
>  -- drop instances of MODULE_DEVICE_TABLE which is a no-op built-in.
> 
>  -- replace module_init (if present) with device_initcall, which is
>     functionally identical once CPP has processed the source.
> 
>  -- drop instances of MODULE_LICENSE, MODULE_AUTHOR, MODULE_DESCRIPTION
>     while ensuring the contained info is present in the file comments.
> 
> Build tested for allmodconfig on several arch, including ARM and ARM-64
> on a recent linux-next baseline.
> 
> Some non-modular PCI files still remain with unused __exit and/or .remove
> functions.  Those will be dealt with in a separate series after this.
> 
> Also note that we looked into modularizing some of the PCI_DW stuff at
> an earlier time[1] but that ran into problems such as trying to create
> unwind for hook_fault_code etc. that wasn't easily solved.  So we just
> go with keeping the code runtime functionally equivalent to what it was.
> 
> Paul.
> 
> [1] https://lkml.kernel.org/r/1454889644-27830-1-git-send-email-paul.gortmaker@windriver.com
> 
> ---
> 
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Ley Foon Tan <lftan@altera.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Pratyush Anand <pratyush.anand@gmail.com>
> Cc: Richard Zhu <Richard.Zhu@freescale.com>
> Cc: Tom Long Nguyen <tom.l.nguyen@intel.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: rfi@lists.rocketboards.org
> Cc: linux-pci@vger.kernel.org
> Cc: linux-samsung-soc@vger.kernel.org
> 
> Paul Gortmaker (8):
>   PCI: altera: make msi explicitly non-modular
>   PCI: altera: make it explicitly non-modular
>   PCI: imx6: make it explicitly non-modular
>   PCI: portdrv: make it explicitly non-modular
>   PCI: spear13xx: make it explicitly non-modular
>   PCI: designware: make host support explicitly non-modular
>   PCI: exynos: make host support explicitly non-modular
>   PCI: generic: make host-common explicitly non-modular
> 
>  drivers/pci/host/pci-exynos.c      |  7 +------
>  drivers/pci/host/pci-host-common.c |  7 ++-----
>  drivers/pci/host/pci-imx6.c        |  9 +--------
>  drivers/pci/host/pcie-altera-msi.c | 10 +++++-----
>  drivers/pci/host/pcie-altera.c     | 12 +++++-------
>  drivers/pci/host/pcie-designware.c |  5 -----
>  drivers/pci/host/pcie-spear13xx.c  | 11 ++---------
>  drivers/pci/pcie/portdrv_pci.c     |  8 +-------
>  8 files changed, 17 insertions(+), 52 deletions(-)

I applied all these to pci/demodularize for v4.9, thanks, Paul!