From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbcHXEnv (ORCPT ); Wed, 24 Aug 2016 00:43:51 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58995 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbcHXEnt (ORCPT ); Wed, 24 Aug 2016 00:43:49 -0400 Date: Tue, 23 Aug 2016 21:43:46 -0700 From: Stephen Boyd To: Sylwester Nawrocki Cc: Chanwoo Choi , tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org, k.kozlowski@samsung.com, chanwoo@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section Message-ID: <20160824044346.GR6502@codeaurora.org> References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> <57BBB66E.2060807@samsung.com> <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23, Sylwester Nawrocki wrote: > On 08/23/2016 04:35 AM, Chanwoo Choi wrote: > I checked stripped object files and it seems with the patch there > is some saving of the kernel image size. Exactly 784 bytes, which > makes zImage smaller by 480 bytes. > > The patch increases .init.rodata section size by 780 bytes but > decreases .init.text section size by 1564 bytes. Looks like > a static initializer is cheaper. > > $ ls -l drivers/clk/samsung/clk-exynos5260.o > > < -rw-rw-r-- 1 snawrocki snawrocki 29100 Aug 23 11:35 drivers/clk/samsung/clk-exynos5260.o > --- > > -rw-rw-r-- 1 snawrocki snawrocki 28316 Aug 23 11:32 drivers/clk/samsung/clk-exynos5260.o > > > The section size differences are as below: > 15c15 > < 3 .init.text 000006b8 00000000 00000000 00000034 2**2 > --- > > 3 .init.text 0000009c 00000000 00000000 00000034 2**2 > 25c25 > < 8 .init.rodata 00003f6c 00000000 00000000 00002f20 2**2 > --- > > 8 .init.rodata 00004278 00000000 00000000 00002904 2**2 > > So the saving is rather insignificant but the patch doesn't make > things worse and I'd say it might be worth applying. > Sounds good. This sort of information should be in the commit text though. Talking about const doesn't make any sense to me. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project