* [PATCH v2 1/2] ASoC: simple-card-utils: add __printf attribute
@ 2016-08-24 15:23 Nicolas Iooss
2016-08-24 15:23 ` [PATCH v2 2/2] MAINTAINERS: document ASoC header files Nicolas Iooss
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2016-08-24 15:23 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Kuninori Morimoto, alsa-devel; +Cc: linux-kernel
asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format
some of its arguments. Adding a __printf attribute to this function
makes it possible to detect at compile-time errors related to format
strings.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
include/sound/simple_card_utils.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
index 86088aed9002..3207b1a70d38 100644
--- a/include/sound/simple_card_utils.h
+++ b/include/sound/simple_card_utils.h
@@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev,
struct device_node *codec,
char *prefix,
unsigned int *retfmt);
+__printf(3, 4)
int asoc_simple_card_set_dailink_name(struct device *dev,
struct snd_soc_dai_link *dai_link,
const char *fmt, ...);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] MAINTAINERS: document ASoC header files
2016-08-24 15:23 [PATCH v2 1/2] ASoC: simple-card-utils: add __printf attribute Nicolas Iooss
@ 2016-08-24 15:23 ` Nicolas Iooss
2016-08-25 0:37 ` Kuninori Morimoto
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2016-08-24 15:23 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Kuninori Morimoto, alsa-devel; +Cc: linux-kernel
include/sound/simple_card_utils.h is handled by ASoC maintainers, as
stated in https://lkml.org/lkml/2016/8/22/307, and
include/sound/simple_card.h seems to be an ASoC file too. In the future
there will be more files named like these ones so introduce a pattern to
match them.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0bbe4b105c34..3f4e8bf042b9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11012,6 +11012,7 @@ S: Supported
F: Documentation/devicetree/bindings/sound/
F: Documentation/sound/alsa/soc/
F: sound/soc/
+F: include/sound/simple*card*
F: include/sound/soc*
SOUND - DMAENGINE HELPERS
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: document ASoC header files
2016-08-24 15:23 ` [PATCH v2 2/2] MAINTAINERS: document ASoC header files Nicolas Iooss
@ 2016-08-25 0:37 ` Kuninori Morimoto
0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2016-08-25 0:37 UTC (permalink / raw)
To: Nicolas Iooss; +Cc: Liam Girdwood, Mark Brown, alsa-devel, linux-kernel
Hi
> include/sound/simple_card_utils.h is handled by ASoC maintainers, as
> stated in https://lkml.org/lkml/2016/8/22/307, and
> include/sound/simple_card.h seems to be an ASoC file too. In the future
> there will be more files named like these ones so introduce a pattern to
> match them.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-25 4:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-24 15:23 [PATCH v2 1/2] ASoC: simple-card-utils: add __printf attribute Nicolas Iooss
2016-08-24 15:23 ` [PATCH v2 2/2] MAINTAINERS: document ASoC header files Nicolas Iooss
2016-08-25 0:37 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).