From: David Miller <davem@redhat.com>
To: xander.huff@ni.com
Cc: f.fainelli@gmail.com, sergei.shtylyov@cogentembedded.com,
netdev@vger.kernel.org, brad.mouring@ni.com,
linux-kernel@vger.kernel.org, nathan.sullivan@ni.com
Subject: Re: [PATCH v2] Revert "phy: IRQ cannot be shared"
Date: Thu, 25 Aug 2016 16:54:40 -0700 (PDT) [thread overview]
Message-ID: <20160825.165440.1378074913181996224.davem@redhat.com> (raw)
In-Reply-To: <1472075273-16257-1-git-send-email-xander.huff@ni.com>
From: Xander Huff <xander.huff@ni.com>
Date: Wed, 24 Aug 2016 16:47:53 -0500
> This reverts:
> commit 33c133cc7598 ("phy: IRQ cannot be shared")
>
> On hardware with multiple PHY devices hooked up to the same IRQ line, allow
> them to share it.
>
> Sergei Shtylyov says:
> "I'm not sure now what was the reason I concluded that the IRQ sharing
> was impossible... most probably I thought that the kernel IRQ handling
> code exited the loop over the IRQ actions once IRQ_HANDLED was returned
> -- which is obviously not so in reality..."
>
> Signed-off-by: Xander Huff <xander.huff@ni.com>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
> Note: this reverted code fails "CHECK: Alignment should match open
> parentesis"
That's fine, we can fix up the indentation later.
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-08-26 0:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 17:53 [PATCH] phy: request shared IRQ Xander Huff
2016-08-24 18:41 ` Sergei Shtylyov
2016-08-24 21:15 ` Xander Huff
2016-08-24 21:47 ` [PATCH v2] Revert "phy: IRQ cannot be shared" Xander Huff
2016-08-25 23:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825.165440.1378074913181996224.davem@redhat.com \
--to=davem@redhat.com \
--cc=brad.mouring@ni.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=xander.huff@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).