From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755976AbcHYE6H (ORCPT ); Thu, 25 Aug 2016 00:58:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46420 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862AbcHYE6E (ORCPT ); Thu, 25 Aug 2016 00:58:04 -0400 Date: Wed, 24 Aug 2016 17:11:09 -0700 From: Stephen Boyd To: Chanwoo Choi Cc: Sylwester Nawrocki , tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org, k.kozlowski@samsung.com, chanwoo@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section Message-ID: <20160825001109.GO19826@codeaurora.org> References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> <57BBB66E.2060807@samsung.com> <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> <20160824044346.GR6502@codeaurora.org> <57BD5CFB.5050500@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57BD5CFB.5050500@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24, Chanwoo Choi wrote: > On 2016년 08월 24일 13:43, Stephen Boyd wrote: > > On 08/23, Sylwester Nawrocki wrote: > >> So the saving is rather insignificant but the patch doesn't make > >> things worse and I'd say it might be worth applying. > >> > > > > Sounds good. This sort of information should be in the commit > > text though. Talking about const doesn't make any sense to me. > > Do you mean that 'const' is initconst secion? No. Marking it as initconst in the patch is correct. > If possible, could you explain the anything > why you don't make sense about 'const'? > I'm just saying that the reasoning to move it from the text section to the data section shouldn't be because of const. There should be better reasons to do this, like size benefits. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project