From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933410AbcHYIfh (ORCPT ); Thu, 25 Aug 2016 04:35:37 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:51147 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758647AbcHYIfg (ORCPT ); Thu, 25 Aug 2016 04:35:36 -0400 Date: Thu, 25 Aug 2016 15:47:01 +0800 From: Herbert Xu To: Martin Schwidefsky Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build warning after merge of the crypto tree Message-ID: <20160825074701.GA11175@gondor.apana.org.au> References: <20160825113824.61ca7364@canb.auug.org.au> <20160825082010.5523ae6f@mschwide> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160825082010.5523ae6f@mschwide> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 08:20:10AM +0200, Martin Schwidefsky wrote: > On Thu, 25 Aug 2016 11:38:24 +1000 > Stephen Rothwell wrote: > > > Hi Herbert, > > > > After merging the crypto tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > crypto/xor.c: In function 'calibrate_xor_blocks': > > crypto/xor.c:156:1: warning: label 'out' defined but not used [-Wunused-label] > > out: > > ^ > > > > Introduced by commit > > > > 39457acda913 ("crypto: xor - skip speed test if the xor function is selected automatically") > > > > This build does not have XOR_SELECT_TEMPLATE set. > > Hmm, this is probably the best option to get rid of the warning: I'm going to do something like this: ---8<--- This patch fixes an unused label warning triggered when the macro XOR_SELECT_TEMPLATE is not set. Fixes: 39457acda913 ("crypto: xor - skip speed test if the xor...") Reported-by: Stephen Rothwell Signed-off-by: Herbert Xu diff --git a/crypto/xor.c b/crypto/xor.c index b8975d9..69866e9 100644 --- a/crypto/xor.c +++ b/crypto/xor.c @@ -113,13 +113,14 @@ calibrate_xor_blocks(void) #ifdef XOR_SELECT_TEMPLATE fastest = XOR_SELECT_TEMPLATE(fastest); +#endif + if (fastest) { printk(KERN_INFO "xor: automatically using best " "checksumming function %-10s\n", fastest->name); goto out; } -#endif /* * Note: Since the memory is not actually used for _anything_ but to -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt