From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the crypto tree
Date: Thu, 25 Aug 2016 08:20:10 +0200 [thread overview]
Message-ID: <20160825082010.5523ae6f@mschwide> (raw)
In-Reply-To: <20160825113824.61ca7364@canb.auug.org.au>
On Thu, 25 Aug 2016 11:38:24 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Herbert,
>
> After merging the crypto tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> crypto/xor.c: In function 'calibrate_xor_blocks':
> crypto/xor.c:156:1: warning: label 'out' defined but not used [-Wunused-label]
> out:
> ^
>
> Introduced by commit
>
> 39457acda913 ("crypto: xor - skip speed test if the xor function is selected automatically")
>
> This build does not have XOR_SELECT_TEMPLATE set.
Hmm, this is probably the best option to get rid of the warning:
--
diff --git a/crypto/xor.c b/crypto/xor.c
index b8975d9..f00edfc 100644
--- a/crypto/xor.c
+++ b/crypto/xor.c
@@ -117,7 +117,8 @@ calibrate_xor_blocks(void)
printk(KERN_INFO "xor: automatically using best "
"checksumming function %-10s\n",
fastest->name);
- goto out;
+ active_template = fastest;
+ return 0;
}
#endif
@@ -153,7 +154,6 @@ calibrate_xor_blocks(void)
#undef xor_speed
free_pages((unsigned long)b1, 2);
-out:
active_template = fastest;
return 0;
}
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2016-08-25 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 1:38 linux-next: build warning after merge of the crypto tree Stephen Rothwell
2016-08-25 6:20 ` Martin Schwidefsky [this message]
2016-08-25 7:47 ` Herbert Xu
2016-08-25 11:14 ` Stephen Rothwell
2016-08-26 15:19 ` crypto: xor - Fix warning when XOR_SELECT_TEMPLATE is unset Herbert Xu
2017-07-31 2:17 linux-next: build warning after merge of the crypto tree Stephen Rothwell
2017-07-31 13:50 ` Gary R Hook
2018-01-19 1:49 Stephen Rothwell
2018-01-19 4:21 ` Harsh Jain
2018-01-19 5:12 ` Herbert Xu
2018-03-19 1:04 Stephen Rothwell
2018-03-19 5:44 ` Harsh Jain
2018-10-05 5:31 Stephen Rothwell
2019-02-04 0:01 Stephen Rothwell
2019-08-23 3:14 Stephen Rothwell
2019-08-25 18:01 ` Hans de Goede
2022-07-11 10:49 Stephen Rothwell
2022-11-21 1:52 Stephen Rothwell
2024-02-12 3:48 Stephen Rothwell
2024-02-12 12:59 ` Cabiddu, Giovanni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825082010.5523ae6f@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).