From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934423AbcHYN7s (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 09:59:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2991 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934202AbcHYN7r (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 09:59:47 -0400
Date: Thu, 25 Aug 2016 15:59:43 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com,
        acme@kernel.org, alexander.shishkin@linux.intel.com,
        wangnan0@huawei.com, hemant@linux.vnet.ibm.com,
        naveen.n.rao@linux.vnet.ibm.com, mpetlan@redhat.com
Subject: Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled
 without optimization
Message-ID: <20160825135943.GB16482@krava>
References: <1470214725-5023-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>
 <1470214725-5023-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com>
 <20160825215004.11182efd6f5309cd3af5a3fe@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160825215004.11182efd6f5309cd3af5a3fe@kernel.org>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 25 Aug 2016 13:59:46 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote:

SNIP

> > After applying patch:
> > 
> >   $ ./perf probe -x ./test 'foo i'
> >   $ cat /sys/kernel/debug/tracing/uprobe_events
> >     p:probe_test/foo /home/ravi/test:0x0000000000000541 i=-4(%bp):s32
> > 
> >   $ ./perf record -e probe_test:foo ./test
> >   $ ./perf script
> >     test  6300 [001]  5877.879327: probe_test:foo: (400541) i=42
> > 
> > No need to skip prologue for optimized case since debug info is correct
> > for each instructions for -O2 -g. For more details please visit:
> >         https://bugzilla.redhat.com/show_bug.cgi?id=612253#c6
> > 
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> 
> Looks good for me:)
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> Jiri, Michael, please try this. Ravi's patch can fix your problem.

yes, that fixes the problem for me

thanks a lot,
jirka