From: Wolfram Sang <wsa@the-dreams.de>
To: Shardar Mohammed <smohammed@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed
Date: Thu, 25 Aug 2016 21:39:53 +0200 [thread overview]
Message-ID: <20160825193952.GC1614@katana> (raw)
In-Reply-To: <6d21b4bd199844e3a359cc52823045db@bgmail102.nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
> > > + err = readx_poll_timeout(readl, i2c_dev->base + reg_offset,
> > > + val, val == 0, 1000,
> > > + I2C_CONFIG_LOAD_TIMEOUT);
> >
> > Any reason we can't use readl_poll_timeout() here?
> [Shardar] Can be used, will change and push the new patchset.
Still interested? Should be an easy change, but I am reluctant to fix it
here with no testing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-25 19:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 13:37 [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed Shardar Shariff Md
2016-05-27 13:37 ` [PATCH v8 2/3] i2c: tegra: add separate function for config_load programing Shardar Shariff Md
2016-05-27 13:37 ` [PATCH v8 3/3] i2c: tegra: proper handling of error cases Shardar Shariff Md
2016-06-19 17:21 ` [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed Wolfram Sang
2016-06-19 18:21 ` Shardar Mohammed
2016-08-25 19:39 ` Wolfram Sang [this message]
2016-08-26 9:19 ` Shardar Mohammed
2016-08-26 15:53 ` Wolfram Sang
2016-08-30 19:16 ` Shardar Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825193952.GC1614@katana \
--to=wsa@the-dreams.de \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smohammed@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).