From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755634AbcHYK4Q (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 06:56:16 -0400
Received: from mail.kernel.org ([198.145.29.136]:50880 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754249AbcHYK4O (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 06:56:14 -0400
Date: Thu, 25 Aug 2016 19:48:16 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RFC PATCH 2/4] perf-probe: Add offline output directory option
Message-Id: <20160825194816.471b954460d3a897ed9c0cae@kernel.org>
In-Reply-To: <20160824125845.GB10063@kernel.org>
References: <147201825017.5713.10732844032749364745.stgit@devbox>
        <147201829193.5713.7794866764620845084.stgit@devbox>
        <20160824125845.GB10063@kernel.org>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 24 Aug 2016 09:58:45 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> 
> Also please fix the OPT_STRING string, it should start with a capital
> letter:
> 
>         --max-probes <n>  Set how many probe points can be found for a probe.
>         --no-inlines      Don't search inlined functions
>         --outdir <directory>
>                           path to offline output directory
>         --range           Show variables location range in scope (with --vars only)
> 
> 
> See how it stands out? All the others start with a capital letter.

BTW, actually in most case, perf shows option explanations start without a captal letter,

./perf lock

 Usage: perf lock [<options>] {record|report|script|info}

    -D, --dump-raw-trace  dump raw trace in ASCII
    -i, --input <file>    input file name
    -v, --verbose         be more verbose (show symbol address, etc)

etc. Some commands (including probe) mixing it...

Thanks,

-- 
Masami Hiramatsu <mhiramat@kernel.org>