From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Felix Fietkau" <nbd@nbd.name>,
"David Woodhouse" <dwmw2@infradead.org>,
"Jörg Rödel" <jroedel@suse.de>, "Joerg Roedel" <joro@8bytes.org>,
"Roman Pen" <r.peniaev@gmail.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Ming Lei" <ming.lei@canonical.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Marek" <mmarek@suse.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Vikram Mulukutla" <markivx@codeaurora.org>,
"Stephen Boyd" <stephen.boyd@linaro.org>,
zohar@linux.vnet.ibm.com, "Mark Brown" <broonie@kernel.org>,
"Takashi Iwai" <tiwai@suse.de>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Christian Lamparter" <chunkeey@googlemail.com>,
hauke@hauke-m.de, "Josh Boyer" <jwboyer@fedoraproject.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
jslaby@suse.com, "Linus Torvalds" <torvalds@linux-foundation.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Wu Fengguang" <fengguang.wu@intel.com>,
rpurdie@rpsys.net, j.anaszewski@samsung.com,
Abhay_Salunke@dell.com, "Julia Lawall" <Julia.Lawall@lip6.fr>,
Gilles.Muller@lip6.fr, nicolas.palix@imag.fr,
"Tom Gundersen" <teg@jklm.no>,
"David Howells" <dhowells@redhat.com>,
"Alessandro Rubini" <rubini@gnudd.com>,
"Kevin Cernekee" <cernekee@gmail.com>,
"Kees Cook" <keescook@chromium.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Thierry Martinez" <martinez@nsup.org>,
cocci@systeme.lip6.fr, linux-serial@vger.kernel.org,
linux-doc@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe
Date: Thu, 25 Aug 2016 22:25:49 +0200 [thread overview]
Message-ID: <20160825202549.GF3296@wotan.suse.de> (raw)
In-Reply-To: <CAKMK7uFGSKpwrz2gdG=AFiPkdrdtyxpVMkk6QbdVDy-q4G1ZrA@mail.gmail.com>
On Thu, Aug 25, 2016 at 10:10:52PM +0200, Daniel Vetter wrote:
> Cutting down since a lot of this is probably better discussed at
> ks/lpc. Aside, if you want to check out Chris Wilson's work on our new
> depency handling, it's called kfence.
>
> https://lkml.org/lkml/2016/7/17/37
Thanks more reading.. :)
> On Thu, Aug 25, 2016 at 9:41 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> >> > So .. I agree, let's avoid the hacks. Patches welcomed.
> >>
> >> Hm, this is a definite change of tack - back when I discussed this
> >> with Greg about 2 ks ago it sounded like "don't do this". The only
> >> thing we need is some way to wait for rootfs before we do the
> >> request_firmware. Everything else we handle already in the kernel.
> >
> > OK so lets just get this userspace event done, and we're set.
>
> Ah great. As long as that special wait-for-rootfs-pls firmware request
> is still allowed, i915&gfx folks will be happy. We will call it from
> probe though ;-) but all from our own workers.
We should strive for this to be transparent to drivers, ie, this safeguard of
looking for firmware should be something handled by the kernel as otherwise
we're just forcing a race condition given the review in the last thread.
Luis
next prev parent reply other threads:[~2016-08-25 20:26 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 22:54 [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2016-08-24 6:55 ` Daniel Vetter
2016-08-24 20:39 ` Luis R. Rodriguez
2016-08-25 11:05 ` Daniel Vetter
2016-08-25 19:41 ` Luis R. Rodriguez
2016-08-25 20:10 ` Daniel Vetter
2016-08-25 20:25 ` Luis R. Rodriguez [this message]
2016-08-25 20:30 ` Dmitry Torokhov
2016-09-02 23:59 ` Luis R. Rodriguez
2016-09-03 0:20 ` [RFC] fs: add userspace critical mounts event support Luis R. Rodriguez
2016-09-03 4:11 ` Linus Torvalds
2016-09-03 4:20 ` Dmitry Torokhov
[not found] ` <CA+55aFz4q5peXAeY9h8o3he7R=wXrBSYkOjMM9TehOw=pPoS+Q@mail.gmail.com>
2016-09-03 17:49 ` Dmitry Torokhov
2016-09-03 18:01 ` Linus Torvalds
2016-09-03 18:10 ` Dmitry Torokhov
2016-09-06 21:52 ` Luis R. Rodriguez
2016-09-06 22:28 ` Bjorn Andersson
2016-09-06 23:14 ` Luis R. Rodriguez
2016-09-24 1:37 ` Herbert, Marc
2016-09-24 17:41 ` Dmitry Torokhov
2016-10-05 0:00 ` Luis R. Rodriguez
2016-10-05 0:12 ` Linus Torvalds
2016-10-05 0:24 ` Luis R. Rodriguez
2016-10-05 0:32 ` Linus Torvalds
2016-10-05 17:38 ` Luis R. Rodriguez
2016-10-05 1:48 ` Josh Triplett
2016-10-05 1:58 ` Linus Torvalds
2016-09-06 17:46 ` Bjorn Andersson
2016-09-06 18:32 ` Linus Torvalds
2016-09-06 21:11 ` Bjorn Andersson
2016-09-06 21:50 ` Linus Torvalds
2016-09-06 23:04 ` Luis R. Rodriguez
2016-09-24 2:51 ` Herbert, Marc
2016-10-04 23:28 ` Luis R. Rodriguez
2016-09-06 22:32 ` Luis R. Rodriguez
2016-09-14 2:38 ` Rob Landley
2016-10-05 18:00 ` Luis R. Rodriguez
2016-10-05 18:08 ` Linus Torvalds
2016-10-05 19:46 ` Luis R. Rodriguez
2016-11-08 22:47 ` Luis R. Rodriguez
2016-11-09 9:13 ` Daniel Wagner
2016-11-09 23:40 ` Luis R. Rodriguez
2016-11-15 9:28 ` Johannes Berg
2016-06-16 22:54 ` [PATCH v2 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez
2016-07-07 0:56 ` [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-07-13 21:47 ` Luis R. Rodriguez
2016-07-28 0:41 ` Luis R. Rodriguez
2016-08-03 14:50 ` Luis R. Rodriguez
2016-08-03 15:04 ` Greg KH
2016-08-03 17:06 ` Luis R. Rodriguez
2016-08-03 19:32 ` Greg KH
2016-08-03 19:46 ` Luis R. Rodriguez
2016-07-13 23:52 ` Fengguang Wu
2016-07-14 2:15 ` Luis R. Rodriguez
2016-07-14 2:23 ` Fengguang Wu
2016-07-14 3:08 ` Luis R. Rodriguez
2016-07-14 3:35 ` Fengguang Wu
2016-08-24 0:45 ` [PATCH v3 " mcgrof
2016-08-24 0:45 ` [PATCH v3 1/5] MAINTAINERS: extend firmware_class maintainer list mcgrof
2016-08-24 0:45 ` [PATCH v3 2/5] firmware: annotate thou shalt not request fw on init or probe mcgrof
2016-08-24 8:17 ` Gabriel Paubert
2016-09-02 18:26 ` Luis R. Rodriguez
2016-08-24 0:45 ` [PATCH v3 3/5] firmware: update usermode helper docs and add SmPL report mcgrof
2016-08-24 0:45 ` [PATCH v3 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation mcgrof
2016-08-24 0:45 ` [PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend mcgrof
2016-08-31 7:03 ` Daniel Wagner
2016-09-02 18:13 ` Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez
2016-09-07 6:43 ` Greg KH
2016-09-08 14:58 ` Luis R. Rodriguez
2016-09-08 15:25 ` Ming Lei
2016-09-07 0:42 ` [PATCH v4 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez
2016-09-07 0:42 ` [PATCH v4 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825202549.GF3296@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=Abhay_Salunke@dell.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cernekee@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=chunkeey@googlemail.com \
--cc=cocci@systeme.lip6.fr \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=j.anaszewski@samsung.com \
--cc=johannes@sipsolutions.net \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=jslaby@suse.com \
--cc=jwboyer@fedoraproject.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@amacapital.net \
--cc=markivx@codeaurora.org \
--cc=martinez@nsup.org \
--cc=ming.lei@canonical.com \
--cc=mmarek@suse.com \
--cc=nbd@nbd.name \
--cc=nicolas.palix@imag.fr \
--cc=r.peniaev@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=rubini@gnudd.com \
--cc=stephen.boyd@linaro.org \
--cc=teg@jklm.no \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).