From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755919AbcH1R7s (ORCPT ); Sun, 28 Aug 2016 13:59:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55836 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755719AbcH1R7q (ORCPT ); Sun, 28 Aug 2016 13:59:46 -0400 Date: Sun, 28 Aug 2016 19:59:07 +0200 From: Greg KH To: Joe Perches Cc: "Levin, Alexander" , Sasha Levin , LKML , "ksummit-discuss@lists.linuxfoundation.org" Subject: Re: checkkpatch (in)sanity ? Message-ID: <20160828175907.GA9615@kroah.com> References: <1472330452.26978.23.camel@perches.com> <20160828005636.GB19088@sasha-lappy> <1472348579.26978.47.camel@perches.com> <20160828023807.GC19088@sasha-lappy> <1472404557.26978.84.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1472404557.26978.84.camel@perches.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 28, 2016 at 10:15:57AM -0700, Joe Perches wrote: > On Sat, 2016-08-27 at 22:47 -0400, Levin, Alexander wrote: > > > > By default you should only get the most critical warnings we have in the > > > > kernel like missing S-O-B or corrupt patch. > > > I don't think so, but if you do, add a filter for ERROR only. > > I could, but the problem is the people who see the default output as "holy". > > Personally, I think the "my first kernel patch" beginners were > overly encouraged to produce these checkpatch whitespace type > changes by a couple things: > > o Greg KH's TuxRadar article back in 2010 > http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel > o The Eudyptula Challenge >  http://eudyptula-challenge.org/ > > I don't know if the Eudyptula scripts are specific to > drivers/staging and most of those beginners haven't read his > email from 2015 that essentially says "don't do that" on > anything other than drivers/staging. I have been assured that Eudyptula says to stick only with drivers/staging/ If anyone knows otherwise, please let me know and I will work to resolve that. thanks, greg k-h