From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756609AbcH2HP2 (ORCPT ); Mon, 29 Aug 2016 03:15:28 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51401 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756552AbcH2HP1 (ORCPT ); Mon, 29 Aug 2016 03:15:27 -0400 Date: Mon, 29 Aug 2016 09:15:15 +0200 From: Alexandre Belloni To: "Levin, Alexander" Cc: Joe Perches , "ksummit-discuss@lists.linuxfoundation.org" , Greg KH , Sasha Levin , LKML Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? Message-ID: <20160829071515.wqlpjccq7a3vk7u6@piout.net> References: <1472330452.26978.23.camel@perches.com> <20160828005636.GB19088@sasha-lappy> <1472348579.26978.47.camel@perches.com> <20160828023807.GC19088@sasha-lappy> <1472404557.26978.84.camel@perches.com> <20160828223759.GA12993@sasha-lappy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160828223759.GA12993@sasha-lappy> User-Agent: Mutt/1.6.2-neo (2016-07-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/2016 at 18:37:59 -0400, Levin, Alexander via Ksummit-discuss wrote : > On Sun, Aug 28, 2016 at 01:15:57PM -0400, Joe Perches wrote: > > On Sat, 2016-08-27 at 22:47 -0400, Levin, Alexander wrote: > > > > > Would you agree that by default we shouldn't show anything that's > > > not an error/defect? > > > > Not particularly, no. > > I think that we need to figure out this disagreement first then. My claim is that checkpatch's output isn't useful. > > Based on your bash snippet, populated with the KS program committee + the first few maintainers I spotted on 'git log': > > commiter commits issues > arnd 858 2155 > axboe 53 22 > corbet 15 9 > davem 55 81 > grant.likely 2 0 > gregkh 38 46 > hch 393 581 > James.Bottomley 15 15 > martin.petersen 18 20 > mchehab 678 1042 > mgorman 104 256 > mingo 58 192 > paulmck 176 68 > peterz 226 511 > rostedt 123 178 > shuahkh 53 6 > tglx 200 287 > torvalds 64 89 > tytso 37 77 > viro 350 256 > > And for the last 10,000 commits in the log, that script has observed 10,783 issues. > > It'll be interesting to hear from these people about their view of checkpatch, but IMO when on average there are more issues than commits I can suggest two possible causes: > > 1. People are used to ignore checkpatch warnings. > 2. People aren't using checkpatch. > Well, Arnd is used to move around old code when refactoring. As the code just moves, he rarely solves checkpatch issues when doing so which is the right thing to do. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com