From: Keith Busch <keith.busch@intel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()
Date: Mon, 29 Aug 2016 12:27:35 -0400 [thread overview]
Message-ID: <20160829162735.GD19986@localhost.localdomain> (raw)
In-Reply-To: <2756c572e066ed91a41e35568a4d9346e47d6b42.1472462539.git.luto@kernel.org>
On Mon, Aug 29, 2016 at 02:25:45AM -0700, Andy Lutomirski wrote:
> + /*
> + * A controller "page" may be bigger than a Linux page, but we can
> + * be conservative here.
> + */
It is the actually other way around: the Linux page may be larger than the
controller's. We currently use the smallest possible controller page (4k)
regardless of the host's size due to limitations discovering the CPU's
DMA alignment. PPC was the first to encounter this problem with NVMe.
Otherwise, looks good.
next prev parent reply other threads:[~2016-08-29 16:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 9:25 [PATCH 0/3] nvme power saving Andy Lutomirski
2016-08-29 9:25 ` [PATCH 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-08-29 9:25 ` [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-08-29 16:27 ` Keith Busch [this message]
2016-08-29 23:20 ` Andy Lutomirski
2016-08-30 6:36 ` Christoph Hellwig
2016-08-30 16:00 ` Andy Lutomirski
2016-08-29 9:25 ` [PATCH 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-08-29 15:07 ` J Freyensee
2016-08-29 23:16 ` Andy Lutomirski
2016-08-30 20:21 ` Andy Lutomirski
2016-09-02 18:11 ` J Freyensee
2016-09-02 18:50 ` Andy Lutomirski
2016-08-29 16:45 ` Keith Busch
2016-08-29 23:16 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829162735.GD19986@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).