From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308AbcH2RQ7 (ORCPT ); Mon, 29 Aug 2016 13:16:59 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:43275 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753287AbcH2RQ5 (ORCPT ); Mon, 29 Aug 2016 13:16:57 -0400 Date: Mon, 29 Aug 2016 10:16:51 -0700 From: Josh Triplett To: Joe Perches Cc: Arnd Bergmann , ksummit-discuss@lists.linuxfoundation.org, Greg KH , Sasha Levin , LKML Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? Message-ID: <20160829171651.GA27257@cloud> References: <1472330452.26978.23.camel@perches.com> <20160828223759.GA12993@sasha-lappy> <20160829071515.wqlpjccq7a3vk7u6@piout.net> <5149968.BflLUdM3a8@wuerfel> <1472474879.3425.30.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1472474879.3425.30.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2016 at 05:47:59AM -0700, Joe Perches wrote: > I generally don't run it on my own patches, mostly out > of possibly misplaced confidence in my own adherence to > the nominal kernel style.  It sometimes leads to mild > regret over things like whitespace defects. In the specific case of whitespace defects, does git diff not catch those? For that matter, should we add a .gitattributes file to the kernel enabling additional whitespace errors git knows how to catch? git.git has such a file.