From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932265AbcH2TGg (ORCPT ); Mon, 29 Aug 2016 15:06:36 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:40714 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755157AbcH2TGf (ORCPT ); Mon, 29 Aug 2016 15:06:35 -0400 Date: Mon, 29 Aug 2016 22:06:18 +0300 From: Dan Carpenter To: Joe Perches Cc: Sasha Levin , alexander.levin@verizon.com, Greg KH , LKML , ksummit-discuss@lists.linuxfoundation.org Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? Message-ID: <20160829190618.GF4180@mwanda> References: <1472330452.26978.23.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472330452.26978.23.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I would like a couple changes which you know already: 1) Get rid of PREFER_ETHER_ADDR_COPY and similar because the people who send checkpatch.pl fixes aren't qualified to say when it's legal or not so they sometimes introduce bugs. 2) We could put some text in the output of --file output to say that if it's not a staging patch, then we don't care about just making checkpatch happy. So consider if it is a waste of maintainer time before sending. regards, dan carpenter