From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755526AbcH2TK0 (ORCPT ); Mon, 29 Aug 2016 15:10:26 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42077 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751983AbcH2TKZ (ORCPT ); Mon, 29 Aug 2016 15:10:25 -0400 Date: Mon, 29 Aug 2016 12:10:20 -0700 From: Josh Triplett To: Dan Carpenter Cc: Joe Perches , ksummit-discuss@lists.linuxfoundation.org, Greg KH , Sasha Levin , LKML Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? Message-ID: <20160829191020.GB27600@cloud> References: <1472330452.26978.23.camel@perches.com> <20160829190618.GF4180@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160829190618.GF4180@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2016 at 10:06:18PM +0300, Dan Carpenter wrote: > I would like a couple changes which you know already: > > 1) Get rid of PREFER_ETHER_ADDR_COPY and similar because the people who > send checkpatch.pl fixes aren't qualified to say when it's legal or not > so they sometimes introduce bugs. I do think we should have *something* that catches such things. Perhaps not checkpatch.pl, though. Perhaps a compiler plugin that generates additional warnings, and can perhaps use more global information to determine legality?