From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices
Date: Tue, 30 Aug 2016 06:49:51 +0300 [thread overview]
Message-ID: <20160830064857-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <b3183b57-2335-9195-4cf1-bad7b9f30956@redhat.com>
On Tue, Aug 30, 2016 at 11:16:25AM +0800, Jason Wang wrote:
>
>
> On 2016年08月30日 10:27, Michael S. Tsirkin wrote:
> > Legacy virtio devices always bypassed an IOMMU, so using them with vfio was
> > never safe.
>
> And it actually won't work since GPA is assumed in the device. So I'm not
> sure this is must since we should get a IOMMU fault in this case.
We won't get an IOMMU fault for legacy systems since they
bypass the IOMMU. Instead guest userspace will get full
access to all of guest memory through the device.
> > This adds a quirk detecting these and disabling VFIO unless the
> > noiommu mode is used. At the moment, this only applies to virtio-pci devices.
> >
> > The patch might make sense on stable as well.
> >
> > Michael S. Tsirkin (2):
> > vfio: report group noiommu status
> > vfio: add virtio pci quirk
> >
> > drivers/vfio/pci/vfio_pci_private.h | 1 +
> > include/linux/vfio.h | 2 +
> > drivers/vfio/pci/vfio_pci.c | 14 ++++
> > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++
> > drivers/vfio/vfio.c | 12 ++++
> > drivers/vfio/pci/Makefile | 1 +
> > 6 files changed, 170 insertions(+)
> > create mode 100644 drivers/vfio/pci/vfio_pci_virtio.c
> >
prev parent reply other threads:[~2016-08-30 3:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 2:27 [PATCH v2 0/2] vfio: blacklist legacy virtio devices Michael S. Tsirkin
2016-08-30 2:27 ` [PATCH v2 1/2] vfio: report group noiommu status Michael S. Tsirkin
2016-08-30 2:27 ` [PATCH v2 2/2] vfio: add virtio pci quirk Michael S. Tsirkin
2016-08-30 3:23 ` Alex Williamson
2016-08-30 3:48 ` Michael S. Tsirkin
2016-08-30 3:52 ` Alex Williamson
2016-08-30 3:57 ` Michael S. Tsirkin
2016-08-30 4:53 ` Alex Williamson
2016-08-30 5:20 ` Michael S. Tsirkin
2016-08-30 12:46 ` Alex Williamson
2016-08-30 9:59 ` kbuild test robot
2016-08-30 3:16 ` [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices Jason Wang
2016-08-30 3:49 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830064857-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).