From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756405AbcH3InJ (ORCPT ); Tue, 30 Aug 2016 04:43:09 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:47391 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755593AbcH3InG (ORCPT ); Tue, 30 Aug 2016 04:43:06 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Tue, 30 Aug 2016 09:42:54 +0100 From: Charles Keepax To: Chen-Yu Tsai CC: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , , Subject: Re: [alsa-devel] [PATCH 2/4] ASoC: dapm: Fix value setting for _ENUM_DOUBLE MUX's second channel Message-ID: <20160830084254.GX21682@localhost.localdomain> References: <20160827112801.31010-1-wens@csie.org> <20160827112801.31010-3-wens@csie.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160827112801.31010-3-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608300083 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 27, 2016 at 07:27:59PM +0800, Chen-Yu Tsai wrote: > The value for the second channel in _ENUM_DOUBLE (double channel) MUXs > is not correctly updated, due to using the wrong bit shift. > > Use the correct bit shift, so both channels toggle together. > > Fixes: 3727b4968453 ("ASoC: dapm: Consolidate MUXs and value MUXs") > Signed-off-by: Chen-Yu Tsai > --- Reviewed-by: Charles Keepax Thanks, Charles