From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758110AbcHaG5h (ORCPT ); Wed, 31 Aug 2016 02:57:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45238 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342AbcHaG5f (ORCPT ); Wed, 31 Aug 2016 02:57:35 -0400 Date: Wed, 31 Aug 2016 08:57:31 +0200 From: Jiri Olsa To: Mathieu Poirier Cc: acme@kernel.org, mingo@redhat.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, acme@infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2] perf tools: adding support for address filters Message-ID: <20160831065731.GA31764@krava> References: <1472573415-3618-1-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472573415-3618-1-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 31 Aug 2016 06:57:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 10:10:15AM -0600, Mathieu Poirier wrote: > This patch makes it possible to use the current filter > framework with address filters. That way address filters for > HW tracers such as CoreSight and IntelPT can be communicated > to the kernel drivers. > > CC: Alexander Shishkin > Signed-off-by: Mathieu Poirier > > --- > Changes for V2: > - Rebased to v4.8-rc4. > - Revisited error path. > --- > > tools/perf/util/parse-events.c | 30 +++++++++++++++++++++++++----- > 1 file changed, 25 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 2eb8b1ed4cc8..1df413fbf7f8 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1760,12 +1760,26 @@ foreach_evsel_in_last_glob(struct perf_evlist *evlist, > static int set_filter(struct perf_evsel *evsel, const void *arg) > { > const char *str = arg; > + bool found = false; > + int nr_addr_filters = 0; > + struct perf_pmu *pmu = NULL; > > - if (evsel == NULL || evsel->attr.type != PERF_TYPE_TRACEPOINT) { > - fprintf(stderr, > - "--filter option should follow a -e tracepoint option\n"); > - return -1; > - } > + if (evsel == NULL) > + goto err; > + > + while ((pmu = perf_pmu__scan(pmu)) != NULL) > + if (pmu->type == evsel->attr.type) { > + found = true; > + break; > + } > + > + if (found) > + perf_pmu__scan_file(pmu, "nr_addr_filters", > + "%d", &nr_addr_filters); > + > + > + if (evsel->attr.type != PERF_TYPE_TRACEPOINT && !nr_addr_filters) > + goto err; should we display another error message for !nr_addr_filters case? the one below is misleading in this case jirka > > if (perf_evsel__append_filter(evsel, "&&", str) < 0) { > fprintf(stderr, > @@ -1774,6 +1788,12 @@ static int set_filter(struct perf_evsel *evsel, const void *arg) > } > > return 0; > + > +err: > + fprintf(stderr, > + "--filter option should follow a -e tracepoint or HW tracer option\n"); > + > + return -1; > } > > int parse_filter(const struct option *opt, const char *str, > -- > 2.7.4 >