From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759361AbcHaKav (ORCPT ); Wed, 31 Aug 2016 06:30:51 -0400 Received: from foss.arm.com ([217.140.101.70]:57056 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245AbcHaKau (ORCPT ); Wed, 31 Aug 2016 06:30:50 -0400 Date: Wed, 31 Aug 2016 11:30:36 +0100 From: Mark Rutland To: Zhengyu Shen Cc: Shawn Guo , Zhi Li , Frank Li , "linux-arm-kernel@lists.infradead.org" , kernel list , "peterz@infradead.org" , "mingo@redhat.com" , "acme@kernel.org" , "alexander.shishkin@linux.intel.com" Subject: Re: [PATCH v3] Added perf functionality to mmdc driver Message-ID: <20160831102937.GC4783@leverpostej> References: <20160817194253.16300-1-zhengyu.shen@nxp.com> <20160830114329.GB8366@tiger> <20160830125420.GG1223@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 08:01:18PM +0000, Zhengyu Shen wrote: > Hi, I've done some testing with the fuzzer. Great! Many thanks for doing this. > Mmdc was only responsible for one crash which I fixed (had to remove > the event from the pmu properly). Ok. I take it that there will be a v4 appearing shortly with that fix? > Other drivers also cause crashes and the program reports that events are > Throttling. Is this normal? Throttling is normal, and warnings about throttling can (generally) be safely ignored. Crashes are very bad. Do you have any logs from those crashes in other drivers that you can share? It is possible that a bug in one driver causes failures in another (e.g. if events are erroneously grouped together), so it's not alwyas clear if this is an unrelated bug (though if you can trigger the issue without your driver present, it clearly is). Thanks, Mark.