From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933226AbcHaKmd (ORCPT ); Wed, 31 Aug 2016 06:42:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60876 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757702AbcHaKma (ORCPT ); Wed, 31 Aug 2016 06:42:30 -0400 Date: Wed, 31 Aug 2016 12:42:40 +0200 From: Greg KH To: kys@microsoft.com Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com Subject: Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings Message-ID: <20160831104240.GA22573@kroah.com> References: <1467851057-8718-1-git-send-email-kys@exchange.microsoft.com> <1467851105-8773-1-git-send-email-kys@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467851105-8773-1-git-send-email-kys@exchange.microsoft.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2016 at 05:25:02PM -0700, kys@exchange.microsoft.com wrote: > From: Vitaly Kuznetsov > > In preparation for doing wrap around mappings for ring buffers cleanup > vmbus_open() function: > - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel > drivers now); > - kfree(open_info) on error only after we kzalloc() it (not an issue as it > is valid to call kfree(NULL); > - rename poorly named labels; > - use alloc_pages() instead of __get_free_pages() as we need struct page > pointer for future. > > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan > Tested-by: Dexuan Cui > --- > drivers/hv/channel.c | 43 +++++++++++++++++++++++-------------------- > 1 files changed, 23 insertions(+), 20 deletions(-) This patch doesn't apply to the tree due to the other hv patches you sent. Can you respin this series and resend? thanks, greg k-h