From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757337AbcHaMGB (ORCPT ); Wed, 31 Aug 2016 08:06:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:53602 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcHaMF7 (ORCPT ); Wed, 31 Aug 2016 08:05:59 -0400 Date: Wed, 31 Aug 2016 14:05:57 +0200 From: Johannes Thumshirn To: Colin King Cc: Anil Gurumurthy , Sudarsana Kalluru , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bfa: do not dereference port before it is null checked Message-ID: <20160831120557.p3hcqykbdy3qqaui@c203.arch.suse.de> References: <20160830163616.11410-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160830163616.11410-1-colin.king@canonical.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 05:36:16PM +0100, Colin King wrote: > From: Colin Ian King > > port is deferenced before it is null sanity checked, hence > we potentially have a null pointer dereference bug. Instead, > initialise trl_enabled from port->fcs->bfa after we are sure > port is not null. > > Signed-off-by: Colin Ian King > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850