From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934990AbcHaOGB (ORCPT ); Wed, 31 Aug 2016 10:06:01 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:34632 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934317AbcHaOF6 (ORCPT ); Wed, 31 Aug 2016 10:05:58 -0400 Date: Wed, 31 Aug 2016 10:05:56 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] parisc: led: Remove deprecated create_singlethread_workqueue Message-ID: <20160831140556.GF12660@htj.duckdns.org> References: <20160830163343.GA25952@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160830163343.GA25952@Karyakshetra> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 10:03:43PM +0530, Bhaktipriya Shridhar wrote: > The workqueue "led_wq" queues a single work item &led_task and hence > doesn't require ordering. It is involved in managing when and which > chassis LCD/LED gets updated and hence, is not being used on a memory > reclaim path. Hence, it has been converted to use system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > The work item has been sync cancelled in led_halt to ensure that > there are no pending tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun